From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 120C8385E030 for ; Mon, 23 Mar 2020 11:14:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 120C8385E030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7ACC61E581; Mon, 23 Mar 2020 07:14:57 -0400 (EDT) Subject: Re: [PATCH 7/7] [gdb/testsuite] add jit-elf-util.h and run jit function To: "Strasuns, Mihails" , "gdb-patches@sourceware.org" References: <20200218124339.11270-1-mihails.strasuns@intel.com> <20200218124339.11270-8-mihails.strasuns@intel.com> <32519038-95ed-d46e-28cd-0670e0798a02@simark.ca> From: Simon Marchi Message-ID: <1d0ff1a5-dda3-7559-21bb-8783d4fba508@simark.ca> Date: Mon, 23 Mar 2020 07:14:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-16.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2020 11:14:59 -0000 On 2020-03-23 5:23 a.m., Strasuns, Mihails wrote: > Hello, > > Here I was trying to preserve the old test flow as much as possible - I did seem a bit strange to me though. > Original version relies on _not_ having DWARF debug info present (there is a comment about it in .exp file), the > same applies for the refactored one. If you think simply emitting different function names in the first place is > an equivalent change, I am more than happy to get rid of this :) > > Will address rest of comments and submit a new patchset soon, thanks for review! Yes, it's a good idea to keep the tests testing binaries without debug info. But I think it should be possible to generate binaries without debug info, but with the right function names in the first place, isn't it? These are not inter-dependent? Simon