Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Ingham <jingham@apple.com>
To: gdb-patches@sources.redhat.com
Subject: Trivial fix to annota1.exp
Date: Fri, 12 Sep 2003 20:31:00 -0000	[thread overview]
Message-ID: <1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com> (raw)

I think that the backtrace through a signal handler test in annota1.exp 
is wrong.  It uses a "*" in the regexp for the part that is looking for 
the signal handler frame.  Because of that, all the test really does is 
count the number of frames, and require they be three or more frames.  
It doesn't check that a signal frame is on the stack at all.

I think you really need a "+" instead, or I don't understand the point 
of the test.

Is this okay, it still passes on Linux...

Index: annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.12
diff -r1.12 annota1.exp
299c299
<     -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 
$hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler 
called.\r\n\r\n)*\032\032frame-end\r\n\r\n\032\032frame-begin 2 
$hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" {
---
 >     -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 
$hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler 
called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2 
$hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" {

Jim
--
Jim Ingham                                   jingham@apple.com
Developer Tools
Apple Computer


             reply	other threads:[~2003-09-12 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-12 20:31 Jim Ingham [this message]
2003-09-18 19:39 ` Elena Zannoni
2003-09-18 20:20   ` Jim Ingham
2003-09-18 21:20     ` Jim Ingham
2003-09-23 19:00       ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com \
    --to=jingham@apple.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox