From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17417 invoked by alias); 12 Sep 2003 20:31:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17410 invoked from network); 12 Sep 2003 20:31:42 -0000 Received: from unknown (HELO mail-out2.apple.com) (17.254.0.51) by sources.redhat.com with SMTP; 12 Sep 2003 20:31:42 -0000 Received: from mailgate1.apple.com (A17-128-100-225.apple.com [17.128.100.225]) by mail-out2.apple.com (8.12.9/8.12.9) with ESMTP id h8CKVeiZ001886 for ; Fri, 12 Sep 2003 13:31:40 -0700 (PDT) Received: from scv2.apple.com (scv2.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id for ; Fri, 12 Sep 2003 13:31:14 -0700 Received: from [17.201.22.240] (inghji.apple.com [17.201.22.240]) by scv2.apple.com (8.12.9/8.12.9) with ESMTP id h8CKVVWI025652 for ; Fri, 12 Sep 2003 13:31:31 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v599) Content-Transfer-Encoding: 7bit Message-Id: <1DEB1AE2-E560-11D7-9C6D-00039379E320@apple.com> Content-Type: text/plain; charset=US-ASCII; format=flowed To: gdb-patches@sources.redhat.com From: Jim Ingham Subject: Trivial fix to annota1.exp Date: Fri, 12 Sep 2003 20:31:00 -0000 X-SW-Source: 2003-09/txt/msg00273.txt.bz2 I think that the backtrace through a signal handler test in annota1.exp is wrong. It uses a "*" in the regexp for the part that is looking for the signal handler frame. Because of that, all the test really does is count the number of frames, and require they be three or more frames. It doesn't check that a signal frame is on the stack at all. I think you really need a "+" instead, or I don't understand the point of the test. Is this okay, it still passes on Linux... Index: annota1.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v retrieving revision 1.12 diff -r1.12 annota1.exp 299c299 < -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler called.\r\n\r\n)*\032\032frame-end\r\n\r\n\032\032frame-begin 2 $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { --- > -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2 $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { Jim -- Jim Ingham jingham@apple.com Developer Tools Apple Computer