Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Robert Hoehne <robert.hoehne@gmx.net>
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@cygnus.com
Subject: Re: Two patches for the readline lib
Date: Thu, 01 Apr 1999 00:00:00 -0000	[thread overview]
Message-ID: <199903152204.OAA23135@cygnus.com> (raw)
In-Reply-To: <36ED63EB.54B1@cygnus.com>

> In that case, would it be appropriate to use a single macro
> (eg. if defined (__DJGPP__)) to control these changes?  The old
> readline was a hodge-podge of different ifdefs of this sort.
> It'd be nice to keep it under control this time.

At first: I did the patches this way, since there was already
one or two #ifdef __MSDOS__, so I thought this is the way
like it should be. But in general I agree with you, that this is
not the best way. I would do it better if I know where to start.

From other packages I know a way, where you can specify
in a host/target specifc file some conditionals which are then
either included in the source files or including them in the
Makefile so the flags will passed on commandline when compiling.

I would for instance introduce a define like

#define USE_STDIO_IO

to indicate that stdio functions should be used instead of
terminal functions. But I don't know where to specify this
host depended (in my case for DJGPP).

If you can give me some guidelines I will be glad.

Robert

******************************************************
* email:   Robert Hoehne <robert.hoehne@gmx.net>     *
* Post:    Am Berg 3, D-09573 Dittmannsdorf, Germany *
* WWW:     http://www.tu-chemnitz.de/~sho/rho        *
******************************************************


WARNING: multiple messages have this Message-ID
From: Robert Hoehne <robert.hoehne@gmx.net>
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@cygnus.com
Subject: Re: Two patches for the readline lib
Date: Mon, 15 Mar 1999 14:04:00 -0000	[thread overview]
Message-ID: <199903152204.OAA23135@cygnus.com> (raw)
Message-ID: <19990315140400.ES8pA0nNv38q7Cs3miBMK4u8dXo88QbK_Y3ELO6WVKY@z> (raw)
In-Reply-To: <36ED63EB.54B1@cygnus.com>

> In that case, would it be appropriate to use a single macro
> (eg. if defined (__DJGPP__)) to control these changes?  The old
> readline was a hodge-podge of different ifdefs of this sort.
> It'd be nice to keep it under control this time.

At first: I did the patches this way, since there was already
one or two #ifdef __MSDOS__, so I thought this is the way
like it should be. But in general I agree with you, that this is
not the best way. I would do it better if I know where to start.

From other packages I know a way, where you can specify
in a host/target specifc file some conditionals which are then
either included in the source files or including them in the
Makefile so the flags will passed on commandline when compiling.

I would for instance introduce a define like

#define USE_STDIO_IO

to indicate that stdio functions should be used instead of
terminal functions. But I don't know where to specify this
host depended (in my case for DJGPP).

If you can give me some guidelines I will be glad.

Robert

******************************************************
* email:   Robert Hoehne <robert.hoehne@gmx.net>     *
* Post:    Am Berg 3, D-09573 Dittmannsdorf, Germany *
* WWW:     http://www.tu-chemnitz.de/~sho/rho        *
******************************************************


  parent reply	other threads:[~1999-04-01  0:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-14 14:41 Robert Hoehne
1999-03-15 11:48 ` Michael Snyder
1999-04-01  0:00   ` DJ Delorie
1999-03-16 11:09     ` DJ Delorie
1999-04-01  0:00   ` Robert Hoehne [this message]
1999-03-15 14:04     ` Robert Hoehne
1999-04-01  0:00   ` Michael Snyder
1999-04-01  0:00 ` Elena Zannoni
1999-03-23  9:54   ` Elena Zannoni
1999-04-01  0:00 ` Robert Hoehne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199903152204.OAA23135@cygnus.com \
    --to=robert.hoehne@gmx.net \
    --cc=gdb-patches@cygnus.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox