Re: GDB 4.17 Patch for stack aligned i386 code

[John Wehle <john@feith.com>]

> I have a bit of anxiety over including it in 4.18 at this
> late date, because of the potential impact on all x86 configs.

Understandable.  What the time frame for the 4.18 release?  Any
idea of the rough plan for a follow up release? My concerns are:

  1) Backtracing through sigtramps on Solaris is somewhat busted without
     my changes (the Solaris library contains functions which don't use
     %ebp as the frame pointer).  For example ... the backtrace from
     gdb.base/a1-selftest.exp (without my patch) shows:

#0  0x80068745 in _libc_sigprocmask ()
#1  0x80098763 in sigprocmask ()
#2  0x8107cb3 in rl_signal_handler (sig=134509072) at signals.c:156
#3  0x800685b1 in _sigacthandler ()
#4  <signal handler called>
#5  0x800682b8 in _libc_read ()
#6  0x8101ef9 in rl_getc (stream=0x800a9ad4) at readline.c:3123
#7  0x80ffa5b in rl_read_key () at readline.c:578

     The correct backtrace is:

#0  0x80068745 in _libc_sigprocmask ()
#1  0x80098763 in sigprocmask ()
#2  0x8107fe7 in rl_signal_handler (sig=134509096) at signals.c:156
#3  0x800685b1 in _sigacthandler ()
#4  <signal handler called>
#5  0x800682b8 in _libc_read ()
#6  0x80098b33 in read ()
#7  0x810222d in rl_getc (stream=0x81639a0) at readline.c:3123
#8  0x80ffd8f in rl_read_key () at readline.c:578

  2) The egcs patch to eliminate the frame pointer by default on the
     x86 can't be installed until there's debugger support.

I certainly agree that this is a sizable change to the x86 support and
realize that it may not make sense for 4.18 if you guys are close to a
release.  Drat. :-)

-- John
-------------------------------------------------------------------------
|   Feith Systems  |   Voice: 1-215-646-8000  |  Email: john@feith.com  |
|    John Wehle    |     Fax: 1-215-540-5495  |                         |
-------------------------------------------------------------------------