* gdb distclean : arg list too long
@ 1998-04-06 4:43 Philippe De Muyter
0 siblings, 0 replies; 4+ messages in thread
From: Philippe De Muyter @ 1998-04-06 4:43 UTC (permalink / raw)
To: bug-gdb; +Cc: gdb-testers, Ian Lance Taylor
On m68k-motorola-sysv, gdb-4.18.97 fails for gnumake distclean with
do-distclean : arg list too long
Here is a patch.
Sat Apr 4 07:45:45 1998 Philippe De Muyter <phdm@macqel.be>
* Makefile.in (EXTRA_GCC_FLAGS): Useless XFOO=bar definitions removed.
--- ./Makefile.in Sat Apr 4 07:42:36 1998
+++ ./Makefile.in Sat Apr 4 07:19:45 1998
@@ -440,15 +440,15 @@
'RANLIB=$$(RANLIB_FOR_TARGET)' \
'WINDRES=$$(WINDRES_FOR_TARGET)' \
"GCC_FOR_TARGET=$(GCC_FOR_TARGET)" \
- "`if test x'$(LANGUAGES)' != x; then echo 'LANGUAGES=$(LANGUAGES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(STMP_FIXPROTO)' != x; then echo 'STMP_FIXPROTO=$(STMP_FIXPROTO)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIMITS_H_TEST)' != x; then echo 'LIMITS_H_TEST=$(LIMITS_H_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC1_TEST)' != x; then echo 'LIBGCC1_TEST=$(LIBGCC1_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_CFLAGS)' != x; then echo 'LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_DEBUG_CFLAGS)' != x; then echo 'LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_INCLUDES)' != x; then echo 'LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(ENQUIRE)' != x; then echo 'ENQUIRE=$(ENQUIRE)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(BOOT_CFLAGS)' != x; then echo 'BOOT_CFLAGS=$(BOOT_CFLAGS)'; else echo 'XFOO=bar'; fi`"
+ "`if test x'$(LANGUAGES)' != x; then echo 'LANGUAGES=$(LANGUAGES)'; fi`" \
+ "`if test x'$(STMP_FIXPROTO)' != x; then echo 'STMP_FIXPROTO=$(STMP_FIXPROTO)'; fi`" \
+ "`if test x'$(LIMITS_H_TEST)' != x; then echo 'LIMITS_H_TEST=$(LIMITS_H_TEST)'; fi`" \
+ "`if test x'$(LIBGCC1_TEST)' != x; then echo 'LIBGCC1_TEST=$(LIBGCC1_TEST)'; fi`" \
+ "`if test x'$(LIBGCC2_CFLAGS)' != x; then echo 'LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS)'; fi`" \
+ "`if test x'$(LIBGCC2_DEBUG_CFLAGS)' != x; then echo 'LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS)'; fi`" \
+ "`if test x'$(LIBGCC2_INCLUDES)' != x; then echo 'LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES)'; fi`" \
+ "`if test x'$(ENQUIRE)' != x; then echo 'ENQUIRE=$(ENQUIRE)'; fi`" \
+ "`if test x'$(BOOT_CFLAGS)' != x; then echo 'BOOT_CFLAGS=$(BOOT_CFLAGS)'; fi`"
GCC_FLAGS_TO_PASS = $(BASE_FLAGS_TO_PASS) $(EXTRA_GCC_FLAGS)
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <199804040616.IAA15504@mail.macqel.be>]
* Re: gdb distclean : arg list too long
[not found] <199804040616.IAA15504@mail.macqel.be>
@ 1998-04-06 8:59 ` Ian Lance Taylor
1998-04-07 2:20 ` Philippe De Muyter
0 siblings, 1 reply; 4+ messages in thread
From: Ian Lance Taylor @ 1998-04-06 8:59 UTC (permalink / raw)
To: phdm; +Cc: gdb-patches
Date: Sat, 4 Apr 1998 08:16:19 +0200 (MET DST)
From: "Philippe De Muyter" <phdm@macqel.be>
On m68k-motorola-sysv, gdb-4.18.97 fails for gnumake distclean with
do-distclean : arg list too long
Here is a patch.
Sat Apr 4 07:45:45 1998 Philippe De Muyter <phdm@macqel.be>
* Makefile.in (EXTRA_GCC_FLAGS): Useless XFOO=bar definitions removed.
Unfortunately, this patch fails when using GNU make. This patch will
result in passing an empty string to make, and GNU make will report
make: *** empty string invalid as file name. Stop.
We need to be able to quote the the LANGUAGES line, or it won't work
if there are spaces. Because of how shell quoting works, we need to
quote the entire backquoted expression. That in turns implies that we
need to have something in the string, or make won't like it.
Of course this line doesn't matter for a gdb release, but it does
matter for an egcs release.
I don't see a simple solution at this point. We could save a few
characters here and there by using [ -n ] and changing XFOO=bar to
x=y. Would that be enough to make a difference on your host?
Ian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: gdb distclean : arg list too long
1998-04-06 8:59 ` Ian Lance Taylor
@ 1998-04-07 2:20 ` Philippe De Muyter
1998-04-08 10:21 ` Ian Lance Taylor
0 siblings, 1 reply; 4+ messages in thread
From: Philippe De Muyter @ 1998-04-07 2:20 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gdb-patches
>
> Date: Sat, 4 Apr 1998 08:16:19 +0200 (MET DST)
> From: "Philippe De Muyter" <phdm@macqel.be>
>
> On m68k-motorola-sysv, gdb-4.18.97 fails for gnumake distclean with
> do-distclean : arg list too long
> Here is a patch.
>
> Sat Apr 4 07:45:45 1998 Philippe De Muyter <phdm@macqel.be>
>
> * Makefile.in (EXTRA_GCC_FLAGS): Useless XFOO=bar definitions removed.
>
> Unfortunately, this patch fails when using GNU make.
>
> Ian
Would the following way work ?
Thu Apr 7 11:45:45 1998 Philippe De Muyter <phdm@macqel.be>
* Makefile.in (EXTRA_GCC_FLAGS): XFOO=bar lines shortened.
--- Makefile.in Tue Apr 7 11:11:10 1998
+++ Makefile.in Tue Apr 7 11:07:33 1998
@@ -440,15 +440,15 @@
'RANLIB=$$(RANLIB_FOR_TARGET)' \
'WINDRES=$$(WINDRES_FOR_TARGET)' \
"GCC_FOR_TARGET=$(GCC_FOR_TARGET)" \
- "`if test x'$(LANGUAGES)' != x; then echo 'LANGUAGES=$(LANGUAGES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(STMP_FIXPROTO)' != x; then echo 'STMP_FIXPROTO=$(STMP_FIXPROTO)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIMITS_H_TEST)' != x; then echo 'LIMITS_H_TEST=$(LIMITS_H_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC1_TEST)' != x; then echo 'LIBGCC1_TEST=$(LIBGCC1_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_CFLAGS)' != x; then echo 'LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_DEBUG_CFLAGS)' != x; then echo 'LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_INCLUDES)' != x; then echo 'LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(ENQUIRE)' != x; then echo 'ENQUIRE=$(ENQUIRE)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(BOOT_CFLAGS)' != x; then echo 'BOOT_CFLAGS=$(BOOT_CFLAGS)'; else echo 'XFOO=bar'; fi`"
+ "`echo LANGUAGES=$(LANGUAGES) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo STMP_FIXPROTO=$(STMP_FIXPROTO) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo LIMITS_H_TEST=$(LIMITS_H_TEST) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo LIBGCC1_TEST=$(LIBGCC1_TEST) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo ENQUIRE=$(ENQUIRE) | sed -e s/.*=$$/XFOO=bar`" \
+ "`echo BOOT_CFLAGS=$(BOOT_CFLAGS) | sed -e s/.*=$$/XFOO=bar`"
GCC_FLAGS_TO_PASS = $(BASE_FLAGS_TO_PASS) $(EXTRA_GCC_FLAGS)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: gdb distclean : arg list too long
1998-04-07 2:20 ` Philippe De Muyter
@ 1998-04-08 10:21 ` Ian Lance Taylor
0 siblings, 0 replies; 4+ messages in thread
From: Ian Lance Taylor @ 1998-04-08 10:21 UTC (permalink / raw)
To: phdm; +Cc: gdb-patches
Date: Tue, 7 Apr 1998 11:18:15 +0200 (MET DST)
From: "Philippe De Muyter" <phdm@macqel.be>
Would the following way work ?
Thu Apr 7 11:45:45 1998 Philippe De Muyter <phdm@macqel.be>
* Makefile.in (EXTRA_GCC_FLAGS): XFOO=bar lines shortened.
This patch seems to work for me, after fixing the sed expressions.
Thanks for sending it. I've checked it into the development sources
so it will be in future releases. The gdb team can decide whether the
patch should go into this release.
I've appended the patch I actually checked in.
Ian
Index: Makefile.in
===================================================================
RCS file: /cvs/cvsfiles/devo/Makefile.in,v
retrieving revision 1.559
retrieving revision 1.560
diff -u -r1.559 -r1.560
--- Makefile.in 1998/04/06 18:22:46 1.559
+++ Makefile.in 1998/04/08 17:19:42 1.560
@@ -464,15 +464,15 @@
'RANLIB=$$(RANLIB_FOR_TARGET)' \
'WINDRES=$$(WINDRES_FOR_TARGET)' \
"GCC_FOR_TARGET=$(GCC_FOR_TARGET)" \
- "`if test x'$(LANGUAGES)' != x; then echo 'LANGUAGES=$(LANGUAGES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(STMP_FIXPROTO)' != x; then echo 'STMP_FIXPROTO=$(STMP_FIXPROTO)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIMITS_H_TEST)' != x; then echo 'LIMITS_H_TEST=$(LIMITS_H_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC1_TEST)' != x; then echo 'LIBGCC1_TEST=$(LIBGCC1_TEST)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_CFLAGS)' != x; then echo 'LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_DEBUG_CFLAGS)' != x; then echo 'LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(LIBGCC2_INCLUDES)' != x; then echo 'LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(ENQUIRE)' != x; then echo 'ENQUIRE=$(ENQUIRE)'; else echo 'XFOO=bar'; fi`" \
- "`if test x'$(BOOT_CFLAGS)' != x; then echo 'BOOT_CFLAGS=$(BOOT_CFLAGS)'; else echo 'XFOO=bar'; fi`"
+ "`echo 'LANGUAGES=$(LANGUAGES)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'STMP_FIXPROTO=$(STMP_FIXPROTO)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'LIMITS_H_TEST=$(LIMITS_H_TEST)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'LIBGCC1_TEST=$(LIBGCC1_TEST)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'LIBGCC2_CFLAGS=$(LIBGCC2_CFLAGS)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'LIBGCC2_DEBUG_CFLAGS=$(LIBGCC2_DEBUG_CFLAGS)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'LIBGCC2_INCLUDES=$(LIBGCC2_INCLUDES)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'ENQUIRE=$(ENQUIRE)' | sed -e s/.*=$$/XFOO=/`" \
+ "`echo 'BOOT_CFLAGS=$(BOOT_CFLAGS)' | sed -e s/.*=$$/XFOO=/`" \
GCC_FLAGS_TO_PASS = $(BASE_FLAGS_TO_PASS) $(EXTRA_GCC_FLAGS)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~1998-04-08 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-04-06 4:43 gdb distclean : arg list too long Philippe De Muyter
[not found] <199804040616.IAA15504@mail.macqel.be>
1998-04-06 8:59 ` Ian Lance Taylor
1998-04-07 2:20 ` Philippe De Muyter
1998-04-08 10:21 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox