From: Matthieu Longo <matthieu.longo@arm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v1 3/4] gdb/python: migrate Python initialization to use the new config API (PEP 741)
Date: Mon, 27 Apr 2026 16:12:38 +0100 [thread overview]
Message-ID: <1988b6ac-4f67-4dcf-9d37-f6096bdb5302@arm.com> (raw)
In-Reply-To: <877bpwpftk.fsf@tromey.com>
On 24/04/2026 15:56, Tom Tromey wrote:
> Matthieu> + throw_error (GENERIC_ERROR,
> Matthieu> + _("Python initialization failed: memory allocation failed"));
>
>>> No need for the braces. Also this can just be error (...),
>>> throw_error
>>> is normally only for special things.
>
>> How is it supposed to work with error() ?
>> error() calls exit(EXIT_FAILURE).
>
> In gdb error is just a wrapper that throws, see gdbsupport/errors.cc.
>
> Tom
Ok it makes sense now. I hadn't had a look at error() definition in GDB but binutils.
Fixed.
Do you want me to publish a new revision now ?
Or should I wait for your input on patch 4/4 ?
Matthieu
next prev parent reply other threads:[~2026-04-27 15:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 10:51 [PATCH v1 0/4] gdb/python: more fixes again for Python limited C API support Matthieu Longo
2026-04-09 10:51 ` [PATCH v1 1/4] gdb/python: add gdbpy_borrowed_ref Matthieu Longo
2026-04-17 15:40 ` Tom Tromey
2026-04-23 17:31 ` Matthieu Longo
2026-04-09 10:51 ` [PATCH v1 2/4] gdb/python: eval_python_command returns both exit code and result Matthieu Longo
2026-04-17 17:22 ` Tom Tromey
2026-04-23 19:11 ` Matthieu Longo
2026-04-09 10:51 ` [PATCH v1 3/4] gdb/python: migrate Python initialization to use the new config API (PEP 741) Matthieu Longo
2026-04-17 15:53 ` Tom Tromey
2026-04-24 9:41 ` Matthieu Longo
2026-04-24 14:56 ` Tom Tromey
2026-04-27 15:12 ` Matthieu Longo [this message]
2026-04-28 14:44 ` Tom Tromey
2026-04-09 10:51 ` [PATCH v1 4/4] gdb/python: work around missing symbols not yet part of Python limited API Matthieu Longo
2026-04-17 17:26 ` Tom Tromey
2026-04-24 10:14 ` Matthieu Longo
2026-04-15 9:18 ` [PATCH v1 0/4] gdb/python: more fixes again for Python limited C API support Matthieu Longo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1988b6ac-4f67-4dcf-9d37-f6096bdb5302@arm.com \
--to=matthieu.longo@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox