Re: [PATCH v1 2/4] gdb/python: eval_python_command returns both exit code and result

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

> A previous commit [1] centralized the Python code evaluation in the
> helper function eval_python_command(). However, a missed case in
> varobj_set_visualizer() requires both the exit code and the result
> of the evaluation.

> This patch updates eval_python_command() to return both values and
> adjusts existing callers accordingly. It also replaces the use of
> PyRun_String() in varobj_set_visualizer() with a call to
> eval_python_command().

Could we have it just return null on failure?
And always return a gdbpy_ref<>?

> --- a/gdb/python/python.c
> +++ b/gdb/python/python.c
> @@ -299,42 +299,40 @@ gdbpy_check_quit_flag (const struct extension_language_defn *extlang)
>     NULL means that this is evaluating a string, not the contents of a
>     file.  */
 
> -int
> +std::pair<int, gdbpy_ref<>>
>  eval_python_command (const char *command, int start_symbol,
>  		     const char *filename)

Either way I think the comment needs an update to describe the return
result.

> +  if (mainmod == nullptr)
> +    return std::make_pair(-1, nullptr);
 
Space before parens throughout, though of course this is moot if
returning gdbpy_ref<>.

Tom