From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"dblaikie@gmail.com" <dblaikie@gmail.com>
Subject: Re: [PATCH] Use std::vector for displaced_step_inferior_states
Date: Fri, 23 Nov 2018 18:26:00 -0000 [thread overview]
Message-ID: <1930813a-3552-a940-64e8-05ec2f1b159f@ericsson.com> (raw)
In-Reply-To: <1f966d70-b48d-35a9-9841-8d580371c710@redhat.com>
On 2018-11-22 12:17 p.m., Pedro Alves wrote:
>> I did a quick test of having a pointer to displaced_step_inferior_state in the inferior structure (the implementation of displaced_step_inferior_state stays in infrun.c), it seems to work well. Would you prefer that?
>
> I think that would be better, yeah. Either pointer or object (and moving the
> struct to some header), both are fine with me.
Dropping this patch in favor of:
https://sourceware.org/ml/gdb-patches/2018-11/msg00390.html
Simon
prev parent reply other threads:[~2018-11-23 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 3:12 Simon Marchi
2018-11-22 15:32 ` Pedro Alves
2018-11-22 17:05 ` Simon Marchi
2018-11-22 17:17 ` Pedro Alves
2018-11-23 18:26 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1930813a-3552-a940-64e8-05ec2f1b159f@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=dblaikie@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox