Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vlad Ivanov <vlad.ivanov@lab-systems.ru>
To: Andreas Schwab <schwab@suse.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbarch: Add pc_signed field and use it when adjusting BP addresses
Date: Thu, 15 Mar 2018 13:56:00 -0000	[thread overview]
Message-ID: <189181521122210@web9g.yandex.ru> (raw)
In-Reply-To: <mvm8tatlaed.fsf@suse.de>

15.03.2018, 16:46, "Andreas Schwab" <schwab@suse.de>:
>
> What happens if you start with a non-canonical address? The call to
> address_significant wouldn't be needed if adjusted_bpaddr were always
> canonical to begin with.

I don't think MIPS backend can return an address without sign extension.
The call to address_significant was added there before — looking at the
original commit message, another target (AArch64) can return "tagged"
address that needs trimming.

Regards,

Vlad


  reply	other threads:[~2018-03-15 13:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 11:22 vlad.ivanov
2018-03-15 11:34 ` Andreas Schwab
2018-03-15 11:36   ` Vlad Ivanov
2018-03-15 12:59     ` Ulrich Weigand
2018-03-15 13:10       ` Vlad Ivanov
2018-03-15 14:06         ` Ulrich Weigand
2018-03-15 14:23           ` Vlad Ivanov
2018-03-19 14:14       ` Maciej W. Rozycki
2018-03-19 14:29         ` Ulrich Weigand
2018-03-15 13:46     ` Andreas Schwab
2018-03-15 13:56       ` Vlad Ivanov [this message]
2018-03-15 11:43   ` Vlad Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=189181521122210@web9g.yandex.ru \
    --to=vlad.ivanov@lab-systems.ru \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox