From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38104 invoked by alias); 15 Mar 2018 13:56:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38080 invoked by uid 89); 15 Mar 2018 13:56:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*x:5.0, HContent-Transfer-Encoding:8bit X-HELO: forward105o.mail.yandex.net Received: from forward105o.mail.yandex.net (HELO forward105o.mail.yandex.net) (37.140.190.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Mar 2018 13:56:54 +0000 Received: from mxback9j.mail.yandex.net (mxback9j.mail.yandex.net [IPv6:2a02:6b8:0:1619::112]) by forward105o.mail.yandex.net (Yandex) with ESMTP id ACEF44446223; Thu, 15 Mar 2018 16:56:51 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback9j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 8SKGwy3tyP-uoJaHHiP; Thu, 15 Mar 2018 16:56:50 +0300 Received: by web9g.yandex.ru with HTTP; Thu, 15 Mar 2018 16:56:50 +0300 From: Vlad Ivanov To: Andreas Schwab Cc: "gdb-patches@sourceware.org" In-Reply-To: References: <20180315112111.15247-1-vlad.ivanov@lab-systems.ru> <830441521113797@web37j.yandex.ru> Subject: Re: [PATCH] gdbarch: Add pc_signed field and use it when adjusting BP addresses MIME-Version: 1.0 Message-Id: <189181521122210@web9g.yandex.ru> Date: Thu, 15 Mar 2018 13:56:00 -0000 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-SW-Source: 2018-03/txt/msg00299.txt.bz2 15.03.2018, 16:46, "Andreas Schwab" : > > What happens if you start with a non-canonical address? The call to > address_significant wouldn't be needed if adjusted_bpaddr were always > canonical to begin with. I don't think MIPS backend can return an address without sign extension. The call to address_significant was added there before — looking at the original commit message, another target (AArch64) can return "tagged" address that needs trimming. Regards, Vlad