Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Changes to varobj.c
Date: Thu, 29 May 2008 14:40:00 -0000	[thread overview]
Message-ID: <18493.58735.890650.879225@kahikatea.snap.net.nz> (raw)


I apologise if I missed it, but I never saw a patch for the change below.

I can see a stale comment before varobj_update:

   NOTE: This function may delete the caller's varobj. If it
   returns TYPE_CHANGED,...

(varobj_update no longer returns TYPE_CHANGED)

2008-05-28  Vladimir Prus  <vladimir@codesourcery.com>

	Refactor varobj_update interface.
        * varobj.c (varobj_update): Report changes as vector.  Also
        return not just a list of varobj, but a list of special structures
        that tell what exactly has changed.
        * varobj.h (enum varobj_update_error): Rename to
        varobj_scope_status.
        (struct varobj_update_result_t): New.
        (varobj_update): Adjust prototype.
        * mi/mi-cmd-var.c: Adjust for changes.
                           ^^^^^^^^^^^^^^^^^^

It's usual to include the name of changed function in the ChangeLog.

If you want a second pair of eyes, I'm more likely to peer review patches than
changes that have already been comitted

-- 
Nick                                           http://www.inet.net.nz/~nickrob


             reply	other threads:[~2008-05-28 23:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 14:40 Nick Roberts [this message]
2008-05-29 14:49 ` Daniel Jacobowitz
2008-05-29 16:40 ` Vladimir Prus
2008-05-29 16:46   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18493.58735.890650.879225@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=gdb-patches@sourceware.org \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox