From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24910 invoked by alias); 28 May 2008 23:07:10 -0000 Received: (qmail 24500 invoked by uid 22791); 28 May 2008 23:07:09 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 May 2008 23:06:38 +0000 Received: from kahikatea.snap.net.nz (95.63.255.123.dynamic.snap.net.nz [123.255.63.95]) by viper.snap.net.nz (Postfix) with ESMTP id D7FA93DA95C; Thu, 29 May 2008 11:06:35 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 557C18FC6D; Thu, 29 May 2008 11:06:30 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18493.58735.890650.879225@kahikatea.snap.net.nz> Date: Thu, 29 May 2008 14:40:00 -0000 To: Vladimir Prus Cc: gdb-patches@sourceware.org Subject: Changes to varobj.c X-Mailer: VM 7.19 under Emacs 22.2.50.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00746.txt.bz2 I apologise if I missed it, but I never saw a patch for the change below. I can see a stale comment before varobj_update: NOTE: This function may delete the caller's varobj. If it returns TYPE_CHANGED,... (varobj_update no longer returns TYPE_CHANGED) 2008-05-28 Vladimir Prus Refactor varobj_update interface. * varobj.c (varobj_update): Report changes as vector. Also return not just a list of varobj, but a list of special structures that tell what exactly has changed. * varobj.h (enum varobj_update_error): Rename to varobj_scope_status. (struct varobj_update_result_t): New. (varobj_update): Adjust prototype. * mi/mi-cmd-var.c: Adjust for changes. ^^^^^^^^^^^^^^^^^^ It's usual to include the name of changed function in the ChangeLog. If you want a second pair of eyes, I'm more likely to peer review patches than changes that have already been comitted -- Nick http://www.inet.net.nz/~nickrob