From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
To: Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] solib_target_free_so memory leak
Date: Fri, 03 Jan 2020 16:47:00 -0000 [thread overview]
Message-ID: <1846570505.10109537.1578070037429@mail.yahoo.com> (raw)
In-Reply-To: <8736cwv6fl.fsf@tromey.com>
Am Freitag, 3. Januar 2020, 17:41:21 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
>
> >> + xfree (li->offsets);
> >> delete li;
>
>
> Christian> Maybe a better fix would be to change offsets to be a
> Christian> unique_xmalloc_ptr?
>
> Makes sense to me.
I've sent a v2 for this here:
https://sourceware.org/ml/gdb-patches/2019-12/msg01034.html
Regards
Hannes Domani
next prev parent reply other threads:[~2020-01-03 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191224122452.1668-1-ssbssa.ref@yahoo.de>
2019-12-24 12:25 ` [PATCH 1/3] pe_bfd_read_buildid " Hannes Domani via gdb-patches
2019-12-24 12:25 ` [PATCH 3/3] windows_clear_solib " Hannes Domani via gdb-patches
2020-01-03 16:44 ` Tom Tromey
2019-12-24 12:25 ` [PATCH 2/3] solib_target_free_so " Hannes Domani via gdb-patches
2019-12-26 22:55 ` Christian Biesinger via gdb-patches
2020-01-03 16:41 ` Tom Tromey
2020-01-03 16:47 ` Hannes Domani via gdb-patches [this message]
2019-12-25 13:47 ` [PATCH 1/3] pe_bfd_read_buildid " Andrew Burgess
2019-12-25 14:14 ` Hannes Domani via gdb-patches
2019-12-27 16:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1846570505.10109537.1578070037429@mail.yahoo.com \
--to=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox