From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162729-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14693 invoked by alias); 3 Jan 2020 16:47:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14680 invoked by uid 89); 3 Jan 2020 16:47:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*x:WebService, H*x:Mozilla, H*x:20100101, H*r:sk:sonic30
X-HELO: sonic304-22.consmr.mail.ir2.yahoo.com
Received: from sonic304-22.consmr.mail.ir2.yahoo.com (HELO sonic304-22.consmr.mail.ir2.yahoo.com) (77.238.179.147) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jan 2020 16:47:27 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1578070044; bh=qqJgXzS9pfWDLFjlvbGNJEzRp+UIPlZuWb4TJDTvKbM=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=FffNXUM3VzLhzMxtolySD+RhIpU9t4AZ5XirOMJTdNSfXc+X5QpX2g3E3ZBMsbl1ftzBKH8gVDQ8kU+umgC35UJEkJu9ixk5Q9MhqRWGecqLfinjoCVIJ3pM7887QTtFZhQythj1+S079yr/Tzx5jzVAeIVoQK9uxNk6mY8XU620Pii5QyOlmC2wHaIP9uPEs2PTZ+3viDMFzGBKkqI9FbHGNb6Orjhd++gTcUUs7E7Jd4AgubxaZOXkHaQsD1x8UDa1grMowN8vU23u8vswhBzCg4fDSFOXxnlb2qz41ABOvLQietvhExzVfN2TrmyeRuhdTGOuWvhyqoHAl1GQHA==
Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Fri, 3 Jan 2020 16:47:24 +0000
Date: Fri, 03 Jan 2020 16:47:00 -0000
From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
Reply-To: Hannes Domani <ssbssa@yahoo.de>
To: Gdb-patches <gdb-patches@sourceware.org>
Message-ID: <1846570505.10109537.1578070037429@mail.yahoo.com>
In-Reply-To: <8736cwv6fl.fsf@tromey.com>
References: <20191224122452.1668-1-ssbssa@yahoo.de> <20191224122452.1668-2-ssbssa@yahoo.de> <CAPTJ0XGWmOm5f+7vzaOC=bri2nGai0q_=OFnCp3LVzi55UohnA@mail.gmail.com> <8736cwv6fl.fsf@tromey.com>
Subject: Re: [PATCH 2/3] solib_target_free_so memory leak
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg00043.txt.bz2

 Am Freitag, 3. Januar 2020, 17:41:21 MEZ hat Tom Tromey <tom@tromey.com> F=
olgendes geschrieben:

> >>>>> "Christian" =3D=3D Christian Biesinger via gdb-patches <gdb-patches=
@sourceware.org> writes:
>
>
> >> +=C2=A0 xfree (li->offsets);
> >> delete li;
>
>
> Christian> Maybe a better fix would be to change offsets to be a
> Christian> unique_xmalloc_ptr?
>
> Makes sense to me.

I've sent a v2 for this here:
https://sourceware.org/ml/gdb-patches/2019-12/msg01034.html


Regards
Hannes Domani