Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression in exec.c (print_section_info) ?
Date: Fri, 02 May 2008 01:05:00 -0000	[thread overview]
Message-ID: <18458.26814.784453.234316@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080501180625.GC3801@adacore.com>

 >... 
 > > I didn't really think of it as a patch, I was just trying to draw
 > > attention to the regression.
 > 
 > This approach is too casual for me. Everyone else writes a ChangeLog,
 > which takes at most 1 min of your time. Please follow this part of
 > the procedure, so that I can review the ChangeLog entry as well.

It was only a one-liner and I was hoping that whoever made the regression would
correct it, perhaps as part of a bigger patch/picture.  With respect I think,
perhaps, you're shooting the messenger.

 >...
 > > Actually it was a context diff - so you can read them!  They just look
 > > similar when lines are added.

 > Argh. Consider sending unified diffs, I think others prefer them too.
 > When I see context diffs, I usually end up converting it to unified...

OK.  On emacs-devel, RMS asks for context diffs but I guess it's the
maintainer's prerogative to choose.

 > Anyway, I ended up checking the attached:

Thanks.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-05-02  1:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28  8:38 Nick Roberts
2008-04-29  7:01 ` Joel Brobecker
2008-04-29 14:29   ` Nick Roberts
2008-05-01 18:07     ` Joel Brobecker
2008-05-02  1:05       ` Nick Roberts [this message]
2008-05-02  5:19         ` Joel Brobecker
2008-05-02 22:29         ` Michael Snyder
2008-05-04  8:34           ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18458.26814.784453.234316@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox