From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27092 invoked by alias); 2 May 2008 01:05:41 -0000 Received: (qmail 27077 invoked by uid 22791); 2 May 2008 01:05:37 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 May 2008 01:05:10 +0000 Received: from kahikatea.snap.net.nz (51.63.255.123.dynamic.snap.net.nz [123.255.63.51]) by viper.snap.net.nz (Postfix) with ESMTP id 424B93DA1ED; Fri, 2 May 2008 13:05:08 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id B07D08FC6D; Fri, 2 May 2008 13:05:03 +1200 (NZST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18458.26814.784453.234316@kahikatea.snap.net.nz> Date: Fri, 02 May 2008 01:05:00 -0000 To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Regression in exec.c (print_section_info) ? In-Reply-To: <20080501180625.GC3801@adacore.com> References: <18453.10856.678467.961230@kahikatea.snap.net.nz> <20080429030510.GA28505@adacore.com> <18454.51085.276103.301144@kahikatea.snap.net.nz> <20080501180625.GC3801@adacore.com> X-Mailer: VM 7.19 under Emacs 22.2.50.2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00056.txt.bz2 >... > > I didn't really think of it as a patch, I was just trying to draw > > attention to the regression. > > This approach is too casual for me. Everyone else writes a ChangeLog, > which takes at most 1 min of your time. Please follow this part of > the procedure, so that I can review the ChangeLog entry as well. It was only a one-liner and I was hoping that whoever made the regression would correct it, perhaps as part of a bigger patch/picture. With respect I think, perhaps, you're shooting the messenger. >... > > Actually it was a context diff - so you can read them! They just look > > similar when lines are added. > Argh. Consider sending unified diffs, I think others prefer them too. > When I see context diffs, I usually end up converting it to unified... OK. On emacs-devel, RMS asks for context diffs but I guess it's the maintainer's prerogative to choose. > Anyway, I ended up checking the attached: Thanks. -- Nick http://www.inet.net.nz/~nickrob