From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix crash in -var-delete
Date: Thu, 08 Nov 2007 05:27:00 -0000 [thread overview]
Message-ID: <18226.40498.13190.723249@kahikatea.snap.net.nz> (raw)
In-Reply-To: <fgt5t6$dn9$1@ger.gmane.org>
> @@ -1292,6 +1292,8 @@ delete_variable_1 (struct cpstack **resu
> for (i = 0; i < VEC_length (varobj_p, var->children); ++i)
> {
> varobj_p child = VEC_index (varobj_p, var->children, i);
> + if (!child)
> + continue;
> if (!remove_from_parent_p)
> child->parent = NULL;
Should child not get removed from the list of its parents' children when
deleted first time round? Then checking for child shouldn't be necessary.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2007-11-08 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 19:58 Vladimir Prus
2007-11-07 20:00 ` Daniel Jacobowitz
2007-11-07 20:07 ` Vladimir Prus
2007-11-07 20:55 ` Joel Brobecker
2007-11-08 8:39 ` Vladimir Prus
2007-11-08 19:19 ` Joel Brobecker
2007-11-08 5:27 ` Nick Roberts [this message]
2007-11-08 7:08 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18226.40498.13190.723249@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox