From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15573 invoked by alias); 8 Nov 2007 05:27:24 -0000 Received: (qmail 15564 invoked by uid 22791); 8 Nov 2007 05:27:24 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Nov 2007 05:27:21 +0000 Received: from kahikatea.snap.net.nz (170.62.255.123.dynamic.snap.net.nz [123.255.62.170]) by viper.snap.net.nz (Postfix) with ESMTP id E4B463DA2C4; Thu, 8 Nov 2007 18:27:16 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 1D4618FC6D; Thu, 8 Nov 2007 18:27:15 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18226.40498.13190.723249@kahikatea.snap.net.nz> Date: Thu, 08 Nov 2007 05:27:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Fix crash in -var-delete In-Reply-To: References: <200711072257.59372.ghost@cs.msu.su> <20071107200024.GA9490@caradoc.them.org> X-Mailer: VM 7.19 under Emacs 23.0.50.42 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00154.txt.bz2 > @@ -1292,6 +1292,8 @@ delete_variable_1 (struct cpstack **resu > for (i = 0; i < VEC_length (varobj_p, var->children); ++i) > { > varobj_p child = VEC_index (varobj_p, var->children, i); > + if (!child) > + continue; > if (!remove_from_parent_p) > child->parent = NULL; Should child not get removed from the list of its parents' children when deleted first time round? Then checking for child shouldn't be necessary. -- Nick http://www.inet.net.nz/~nickrob