From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove iterate_over_block_arg_vars_printing
Date: Tue, 15 Sep 2026 13:28:08 -0400 [thread overview]
Message-ID: <17b90b71-b9cb-425c-8eb6-ed4fdc6e9b4c@simark.ca> (raw)
In-Reply-To: <20260915165634.3008224-1-tromey@adacore.com>
On 2026-09-15 12:56, Tom Tromey wrote:
> Back in commit c76bd1b0 ("Remove symbol lookup of arguments"), I
> removed some old stabs code that performed a double lookup of argument
> symbols.
>
> I was surprised today to find that this double-lookup re-entered the
> tree in commit 2465b9e4 ("gdb: add annotation in 'info locals' command
> for variables shadowing case").
>
> That patch added copies of a couple of block iteration functions. The
> function in question, iterate_over_block_arg_vars_printing, is not
> really needed. This patch removes it, removing the old stabs code as
> a consequence.
I guess the unneeded part is the "we need to look up the argument again
because some things gcc 1 and 2 did". Looks fine to me.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2026-09-15 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 16:56 Tom Tromey
2026-09-15 17:28 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b90b71-b9cb-425c-8eb6-ed4fdc6e9b4c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox