From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rPngAkOAqWr6EQ8AWB0awg (envelope-from ) for ; Tue, 15 Sep 2026 13:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789493314; bh=I8DK1U1toUHad2HbshW6HjBIjbGK6CsIJGQv4uWCvLc=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rXgFLJgrrSBNE7+WRcaJf9EWSbIq3fP/quGK347CvAcjHirNqrptr7KWEZkmxyLxv zPenyZbXMZEPg05mO6VkV7n1g/jkQ9od3aEA9sGqKWrL1keDmAUMfyRo8/yVDUDjKz gcy32uReldTXncBwZRCEbn249wxIP70yNbEx58u4= Received: by simark.ca (Postfix, from userid 112) id A56921E06B; Tue, 15 Sep 2026 13:28:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=P3RH1+aj; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A55341E01F for ; Tue, 15 Sep 2026 13:28:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78E5C4B9DB50 for ; Tue, 15 Sep 2026 17:28:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78E5C4B9DB50 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=P3RH1+aj Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0E6464BA79A8 for ; Tue, 15 Sep 2026 17:28:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E6464BA79A8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E6464BA79A8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789493290; cv=none; b=DFCGGEE19B8n2QaXTr5rxO7HGwA9cJoPV8S38RNcD0iu418hK1sVetIE5NRIXoxwm7IQ9CH2QR4KyE6JUie2UQJqA5Oj2Db5FuhhOHZTey8FPh4HyRBgrlcOHXj857eWs7qSIP3sxXdbRCc+ab4/yi/IJejW7R0vD3XtvnKk+u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789493290; c=relaxed/simple; bh=I8DK1U1toUHad2HbshW6HjBIjbGK6CsIJGQv4uWCvLc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uToArdnmn3eEgL+kBNAzCzZ+0R3leiUaVdfm+yKlikz9gkvEy9Hqdb9fs/3436uG57rzdNXJDfW8bzLMei5YW88dWJWmWXHXF3FjOuihRy3PvAc/73/RSSZbSfm/cfWuVun9MEYvSaWqe2sW2a7coBx3zRgxj77L93uD1vthKiE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=P3RH1+aj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0E6464BA79A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789493288; bh=I8DK1U1toUHad2HbshW6HjBIjbGK6CsIJGQv4uWCvLc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=P3RH1+aji8fCV0S7DjYyGZnAsq4DYCmv+bMuKRTozTjhXw0B49NeBmOkC1XpJW8N9 qlqciBm7au+1K+K9S7fI4Vj+9Ns4b+zvXQHuz2mx28IEWbijxDBfm4qMF5Saf26km0 U5q3VJFF3geT5+lXPytnwoYgJgzqvt6sJNUmGzGY= Received: by simark.ca (Postfix) id D4D0C1E01F; Tue, 15 Sep 2026 13:28:08 -0400 (EDT) Message-ID: <17b90b71-b9cb-425c-8eb6-ed4fdc6e9b4c@simark.ca> Date: Tue, 15 Sep 2026 13:28:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove iterate_over_block_arg_vars_printing To: Tom Tromey , gdb-patches@sourceware.org References: <20260915165634.3008224-1-tromey@adacore.com> From: Simon Marchi Content-Language: en-US In-Reply-To: <20260915165634.3008224-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-15 12:56, Tom Tromey wrote: > Back in commit c76bd1b0 ("Remove symbol lookup of arguments"), I > removed some old stabs code that performed a double lookup of argument > symbols. > > I was surprised today to find that this double-lookup re-entered the > tree in commit 2465b9e4 ("gdb: add annotation in 'info locals' command > for variables shadowing case"). > > That patch added copies of a couple of block iteration functions. The > function in question, iterate_over_block_arg_vars_printing, is not > really needed. This patch removes it, removing the old stabs code as > a consequence. I guess the unneeded part is the "we need to look up the argument again because some things gcc 1 and 2 did". Looks fine to me. Approved-By: Simon Marchi Simon