From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: MI: fix base members in references
Date: Sun, 10 Dec 2006 04:19:00 -0000 [thread overview]
Message-ID: <17787.35236.492750.204386@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200612100114.44118.ghost@cs.msu.su>
Vladimir Prus writes:
> does the code you've added ever does anything?
It seems to handle variable objects of references to pointers correctly.
Have you tried it?
and:
> > Are you saying get_type should use value_type (var->value) instead of
> > var->type?
>
> No. I'm saying that instead of using get_type and then additionally doing
> something with the type, we should directly use value_type (var->value). If
> we want to know how many children a value has, and you know the type of the
> value, it does not make sense to take some other type, do some
> transformation on it, and the hope you'll get the same type. You can just
> use the type that's right.
I don't think so because it looks at target_type not type. But these are
unfamiliar concepts to me, so if you think it can be done more simply, or if my
patch doesn't work, post a patch and I'll try it out.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-12-10 4:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 21:27 Nick Roberts
2006-12-09 21:38 ` Vladimir Prus
2006-12-09 21:50 ` Nick Roberts
2006-12-09 22:15 ` Vladimir Prus
2006-12-10 4:19 ` Nick Roberts [this message]
2006-12-10 11:24 ` Vladimir Prus
2006-12-10 20:09 ` Nick Roberts
2006-12-10 20:42 ` Daniel Jacobowitz
2006-12-10 21:20 ` Nick Roberts
2006-12-11 2:35 ` Daniel Jacobowitz
2006-12-11 5:58 ` Nick Roberts
2006-12-11 7:22 ` Vladimir Prus
2006-12-11 8:03 ` Nick Roberts
-- strict thread matches above, loose matches on Subject: below --
2006-11-29 12:56 Vladimir Prus
2006-12-05 13:23 ` Vladimir Prus
2006-12-05 21:32 ` Jim Blandy
2006-12-05 20:59 ` Nick Roberts
2006-12-05 21:12 ` Daniel Jacobowitz
2006-12-05 21:25 ` Nick Roberts
2006-12-05 21:47 ` Daniel Jacobowitz
2006-12-05 22:27 ` Jim Blandy
2006-12-06 8:44 ` Vladimir Prus
2006-12-07 2:22 ` Nick Roberts
2006-12-07 5:24 ` Nick Roberts
2006-12-07 6:22 ` Vladimir Prus
2006-12-07 6:53 ` Vladimir Prus
2006-12-07 10:36 ` Nick Roberts
2006-12-08 12:53 ` Vladimir Prus
2006-12-09 22:10 ` Vladimir Prus
2006-12-05 20:45 ` Daniel Jacobowitz
2006-12-06 9:04 ` Vladimir Prus
2006-12-06 20:29 ` Joel Brobecker
2006-12-06 20:33 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17787.35236.492750.204386@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox