From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Vladimir Prus <vladimir@codesourcery.com>,
gdb-patches@sources.redhat.com
Subject: Re: MI: fix base members in references
Date: Tue, 05 Dec 2006 21:25:00 -0000 [thread overview]
Message-ID: <17781.58050.562000.498586@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20061205211214.GA28333@nevyn.them.org>
> > Actually Vladimir's other patch, MI/C++/references fixup
> > (http://sourceware.org/ml/gdb-patches/2006-11/msg00373.html), seems to fix
> > this. As it also fixes the more general problem of updating references can
> > this not be applied instead?
>
> They can both go in as far as I'm concerned; I think they're both
> needed. I hadn't got to that one yet.
The comment in varobj.c refers to "Baseclass" and I presume the original author
included the case
TYPE_CODE (value_type (parent->value)) == TYPE_CODE_REF
for a specific reason.
If the patch (fix base members) is a reaction to the reported bug, it's seems
unnecessary with the other patch and therefore, I think it shouldn't be
applied. If you can see more generally that it's needed then thats another
matter, and clearly it should be applied.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-12-05 21:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 12:56 Vladimir Prus
2006-12-05 13:23 ` Vladimir Prus
2006-12-05 21:32 ` Jim Blandy
2006-12-05 20:59 ` Nick Roberts
2006-12-05 21:12 ` Daniel Jacobowitz
2006-12-05 21:25 ` Nick Roberts [this message]
2006-12-05 21:47 ` Daniel Jacobowitz
2006-12-05 22:27 ` Jim Blandy
2006-12-06 8:44 ` Vladimir Prus
2006-12-07 2:22 ` Nick Roberts
2006-12-07 5:24 ` Nick Roberts
2006-12-07 6:22 ` Vladimir Prus
2006-12-07 6:53 ` Vladimir Prus
2006-12-07 10:36 ` Nick Roberts
2006-12-08 12:53 ` Vladimir Prus
2006-12-09 22:10 ` Vladimir Prus
2006-12-05 20:45 ` Daniel Jacobowitz
2006-12-06 9:04 ` Vladimir Prus
2006-12-06 20:29 ` Joel Brobecker
2006-12-06 20:33 ` Vladimir Prus
2006-12-09 21:27 Nick Roberts
2006-12-09 21:38 ` Vladimir Prus
2006-12-09 21:50 ` Nick Roberts
2006-12-09 22:15 ` Vladimir Prus
2006-12-10 4:19 ` Nick Roberts
2006-12-10 11:24 ` Vladimir Prus
2006-12-10 20:09 ` Nick Roberts
2006-12-10 20:42 ` Daniel Jacobowitz
2006-12-10 21:20 ` Nick Roberts
2006-12-11 2:35 ` Daniel Jacobowitz
2006-12-11 5:58 ` Nick Roberts
2006-12-11 7:22 ` Vladimir Prus
2006-12-11 8:03 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17781.58050.562000.498586@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox