From: Nick Roberts <nickrob@snap.net.nz>
To: "David S. Miller" <davem@davemloft.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH]: Fix gdb.mi/mi-regs.exp
Date: Mon, 10 Apr 2006 07:05:00 -0000 [thread overview]
Message-ID: <17466.931.119823.103959@farnswood.snap.net.nz> (raw)
In-Reply-To: <20060409.203142.76326217.davem@davemloft.net>
> > Should there be similar tests for other architectures? If they are only
> > intended for sparc, shouldn't this file be called mi-sparc-regs.exp?
>
> There are "XXX" style comments in there suggesting that strings
> for other platforms should be added.
>
> It is a similar situation to gdb.base/float.exp, knowledgable people
> just have to get around to adding the per-target strings.
But these tests are for the MI interface. Register tests for specific
architectures could presumably go in gdb.base/regs.exp and tests in mi-regs.exp
could be more general e.g just check -data-list-register-names returns a list
of values, count them and use this information for tests on
-data-list-register-values.
Anyway, Daniel will approve your patch, I'm just thinking aloud.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-04-10 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-09 21:53 Nick Roberts
2006-04-10 3:31 ` David S. Miller
2006-04-10 7:05 ` Nick Roberts [this message]
2006-04-10 7:20 ` David S. Miller
2006-04-10 12:43 ` Daniel Jacobowitz
2006-04-11 1:30 ` Nick Roberts
2006-05-05 20:06 ` Daniel Jacobowitz
2006-05-06 0:23 ` Nick Roberts
-- strict thread matches above, loose matches on Subject: below --
2006-04-09 4:21 David S. Miller
2006-05-05 20:06 ` Daniel Jacobowitz
2006-05-05 23:15 ` David S. Miller
2006-05-05 23:21 ` Daniel Jacobowitz
2006-05-05 23:22 ` David S. Miller
2006-05-05 23:35 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17466.931.119823.103959@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=davem@davemloft.net \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox