From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10981 invoked by alias); 10 Apr 2006 07:05:28 -0000 Received: (qmail 10970 invoked by uid 22791); 10 Apr 2006 07:05:27 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Apr 2006 07:05:23 +0000 Received: from farnswood.snap.net.nz (p202-124-115-223.snap.net.nz [202.124.115.223]) by viper.snap.net.nz (Postfix) with ESMTP id 47CD475198B; Mon, 10 Apr 2006 19:05:20 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 0290562A99; Mon, 10 Apr 2006 08:05:07 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17466.931.119823.103959@farnswood.snap.net.nz> Date: Mon, 10 Apr 2006 07:05:00 -0000 To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Fix gdb.mi/mi-regs.exp In-Reply-To: <20060409.203142.76326217.davem@davemloft.net> References: <17465.33321.414493.769813@farnswood.snap.net.nz> <20060409.203142.76326217.davem@davemloft.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00115.txt.bz2 > > Should there be similar tests for other architectures? If they are only > > intended for sparc, shouldn't this file be called mi-sparc-regs.exp? > > There are "XXX" style comments in there suggesting that strings > for other platforms should be added. > > It is a similar situation to gdb.base/float.exp, knowledgable people > just have to get around to adding the per-target strings. But these tests are for the MI interface. Register tests for specific architectures could presumably go in gdb.base/regs.exp and tests in mi-regs.exp could be more general e.g just check -data-list-register-names returns a list of values, count them and use this information for tests on -data-list-register-values. Anyway, Daniel will approve your patch, I'm just thinking aloud. -- Nick http://www.inet.net.nz/~nickrob