Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>
Cc: Daniel Jacobowitz <drow@false.org>,
	ezannoni@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [PING PING] Deal with intermixed 32-bit and 64-bit DWARF sections]
Date: Sat, 26 Feb 2005 09:40:00 -0000	[thread overview]
Message-ID: <16927.63957.770365.49332@localhost.redhat.com> (raw)
In-Reply-To: <7320016418918119@weblx058.utsp.utwente.nl>

M.M. Kettenis writes:
 > Daniel Jacobowitz <drow@false.org> wrote: 
 > 
 > > On Tue, Jan 25, 2005 at 10:06:53PM +0100, Mark Kettenis wrote:
 > > > [ Second ping ]
 > > > 
 > > > [ Elena, I never saw a reaction of you on this.  Could you please
 > > >   review it? ]
 > > > 
 > > > Date: Wed, 10 Nov 2004 22:28:46 +0100 (CET)
 > > > From: Mark Kettenis <kettenis@gnu.org>
 > > > 
 > > > Currently GDB crashes hard when we encounter both 32-bit anbd 64-bit
 > > > DWARF sections within the same compilation unit.  Keeping the mantra
 > > > "Be liberal what you accept, but complain loudly", this patch fixes
 > > > that.
 > > 
 > > Mark,
 > > 
 > > Did you mean to check in the test case without the fix?  Not only does
 > > it fail, it divides by zero, triggering the "infinite SIGFPE" bug
 > > elsewhere reported in our bug database, and adding about ten minutes to
 > > all of my testsuite runs.
 > 
 > Sorry 'bout that.  But Elena didn't review it yet.  Fix is sitting at
 > home so I'll probably (ab)use my global maintainer rights to check this
 > in when I get back this weekend.
 > 

I asked Mark, in response to a private e-mail, to provide a testcase
as a necessary condition for his patch to go in.  No need for
threats.

I fixed the patch for internationalization and changes to an ifdeffed
out function and checked it in.






  parent reply	other threads:[~2005-02-26  4:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-16 19:47 [PING] " Mark Kettenis
2005-01-25 21:07 ` [PING PING] " Mark Kettenis
2005-02-24 20:35   ` Daniel Jacobowitz
     [not found]     ` <7320016418918119@weblx058.utsp.utwente.nl>
2005-02-26  9:40       ` Elena Zannoni [this message]
2005-02-26 11:48         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16927.63957.770365.49332@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=m.m.kettenis@alumnus.utwente.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox