From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31158 invoked by alias); 26 Feb 2005 04:33:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31137 invoked from network); 26 Feb 2005 04:33:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 26 Feb 2005 04:33:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1Q4Xaqc031049 for ; Fri, 25 Feb 2005 23:33:42 -0500 Received: from localhost.redhat.com (vpn50-88.rdu.redhat.com [172.16.50.88]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1Q4XPK24612; Fri, 25 Feb 2005 23:33:26 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 13E521A467A; Fri, 25 Feb 2005 23:23:49 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16927.63957.770365.49332@localhost.redhat.com> Date: Sat, 26 Feb 2005 09:40:00 -0000 To: "M.M. Kettenis" Cc: Daniel Jacobowitz , ezannoni@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [PING PING] Deal with intermixed 32-bit and 64-bit DWARF sections] In-Reply-To: <7320016418918119@weblx058.utsp.utwente.nl> References: <20050223224540.GA4563@nevyn.them.org> <7320016418918119@weblx058.utsp.utwente.nl> X-SW-Source: 2005-02/txt/msg00267.txt.bz2 M.M. Kettenis writes: > Daniel Jacobowitz wrote: > > > On Tue, Jan 25, 2005 at 10:06:53PM +0100, Mark Kettenis wrote: > > > [ Second ping ] > > > > > > [ Elena, I never saw a reaction of you on this. Could you please > > > review it? ] > > > > > > Date: Wed, 10 Nov 2004 22:28:46 +0100 (CET) > > > From: Mark Kettenis > > > > > > Currently GDB crashes hard when we encounter both 32-bit anbd 64-bit > > > DWARF sections within the same compilation unit. Keeping the mantra > > > "Be liberal what you accept, but complain loudly", this patch fixes > > > that. > > > > Mark, > > > > Did you mean to check in the test case without the fix? Not only does > > it fail, it divides by zero, triggering the "infinite SIGFPE" bug > > elsewhere reported in our bug database, and adding about ten minutes to > > all of my testsuite runs. > > Sorry 'bout that. But Elena didn't review it yet. Fix is sitting at > home so I'll probably (ab)use my global maintainer rights to check this > in when I get back this weekend. > I asked Mark, in response to a private e-mail, to provide a testcase as a necessary condition for his patch to go in. No need for threats. I fixed the patch for internationalization and changes to an ifdeffed out function and checked it in.