[PATCH] Fix broken interp.exp testcase

[PATCH] Fix broken interp.exp testcase

[Nick Roberts]

 > The new testcase is failing for me:
 > 
 > Running ../../../src/gdb/testsuite/gdb.base/interp.exp ...
 > PASS: gdb.base/interp.exp: interpreter-exec mi "-var-update *"
 > FAIL: gdb.base/interp.exp: interpreter-exec console "show version"
 > 
 > I committed the attached patch to fix it.

Well it was passing for me, as it does with your patch. I must have something
wrong with my setup.

Running the whole testsuite, I get:

		=== gdb Summary ===

# of expected passes		10077
# of unexpected failures	361
# of unexpected successes	1
# of expected failures		46
# of known failures		60
# of unsupported tests		11
/home/nick/src/gdb/testsuite/../../gdb/gdb version  6.3.50.20050203-cvs -nx


which seems an unacceptable number of fails and makes running the testsuite
rather pointless. Have you any ideas of what I might be doing wrong?

Nick

Re: [PATCH] Fix broken interp.exp testcase

[M.M. Kettenis]

Nick Roberts <nickrob@snap.net.nz> wrote:

>
>  > The new testcase is failing for me:
>  >
>  > Running ../../../src/gdb/testsuite/gdb.base/interp.exp ...
>  > PASS: gdb.base/interp.exp: interpreter-exec mi "-var-update *"
>  > FAIL: gdb.base/interp.exp: interpreter-exec console "show version"
>  >
>  > I committed the attached patch to fix it.
>
> Well it was passing for me, as it does with your patch. I must have something
> wrong with my setup.

Well, the behaviour of expect can be really odd, especially when doing
regexp matches. Nothing to really worry about; just keep it in mind.

> Running the whole testsuite, I get:
>
> 		=== gdb Summary ===
>
> # of expected passes		10077
> # of unexpected failures	361
> # of unexpected successes	1
> # of expected failures		46
> # of known failures		60
> # of unsupported tests		11
> /home/nick/src/gdb/testsuite/../../gdb/gdb version  6.3.50.20050203-cvs -nx
>
>
> which seems an unacceptable number of fails and makes running the testsuite
> rather pointless. Have you any ideas of what I might be doing wrong?

What system is this? It seems unusually high if you're running gdb on
an up-to-date i386 GNU/Linux system, but on other systems (including
older i386 GNU/Linux) the number of failures can be fairly high because
of:

* Bugs in gdb.

* Bugs in the operating system kernel & (thread) libraries.

* Bugs in the compiler you're using.

Mark

[PATCH] Fix broken interp.exp testcase

[Mark Kettenis]

[ Argh... no gdb-patches alias on my laptop. ]

The new testcase is failing for me:

Running ../../../src/gdb/testsuite/gdb.base/interp.exp ...
PASS: gdb.base/interp.exp: interpreter-exec mi "-var-update *"
FAIL: gdb.base/interp.exp: interpreter-exec console "show version"

I committed the attached patch to fix it.

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* gdb.base/interp.exp: Remove trailing \n in gdb_test commands.

Index: gdb.base/interp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/interp.exp,v
retrieving revision 1.1
diff -u -p -r1.1 interp.exp
--- gdb.base/interp.exp 2 Feb 2005 21:12:03 -0000 1.1
+++ gdb.base/interp.exp 7 Feb 2005 02:36:14 -0000
@@ -22,7 +22,7 @@ if $tracelevel then {
 
 gdb_start
 
-gdb_test "interpreter-exec mi \"-var-update *\"\n" "\\^done,changelist=[].*"
-gdb_test "interpreter-exec console \"show version\"\n" "GNU gdb .*"
+gdb_test "interpreter-exec mi \"-var-update *\"" "\\^done,changelist=[].*"
+gdb_test "interpreter-exec console \"show version\"" "GNU gdb .*"
 
 gdb_exit