Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@kealia.com>
Cc: gdb-patches@sources.redhat.com,
	Elena Zannoni <ezannoni@redhat.com>, Jim Blandy <jimb@redhat.com>,
	Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [rfa+6.1]: Revised patch for PR c++/1553
Date: Mon, 15 Mar 2004 19:26:00 -0000	[thread overview]
Message-ID: <16470.493.253043.158843@localhost.redhat.com> (raw)
In-Reply-To: <m3k71vnt7j.fsf@coconut.kealia.com>

David Carlton writes:
 > Here's a revision for my patch for PR c++/1553 that I posted a couple
 > of weeks ago.  The stuff that was in that patch hasn't changed (except
 > for syncing it up with current sources), but this version also
 > includes changes to determine_prefix.  Specifically, it fixes a bug in
 > that code that Daniel pointed out, and it rewrites determine_prefix to
 > use my new determine_class_name function (so that all the class name
 > lookup stuff is in one place) and to look at TYPE_TAG_NAME (to avoid
 > recalculating the same name over and over again if possible).
 > 
 > The determine_prefix stuff could be a separate patch from my earlier
 > changes; I just wanted to get it submitted now because it's possible
 > that there will be a hiccup in my copyright assignment.  Also, it
 > seems like a good idea to get patches into 6.1 as early as possible,
 > to increase the amount of testing that they'll get.
 > 
 > I couldn't come up with any test cases for the new part of the patch;
 > it depends very much on how the compiler is generating output. :-(
 > 
 > Tested on i686-pc-linux-gnu, DWARF-2, several different GCC versions.
 > Ok for mainline and 6.1?
 > 

seems ok, however I wasn't able to apply it cleanly.
Also, there are a couple of C++ style comments that should go.

elena


WARNING: multiple messages have this Message-ID
From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@kealia.com>
Cc: gdb-patches@sources.redhat.com,
	Elena Zannoni <ezannoni@redhat.com>, Jim Blandy <jimb@redhat.com>,
	Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [rfa+6.1]: Revised patch for PR c++/1553
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <16470.493.253043.158843@localhost.redhat.com> (raw)
Message-ID: <20040319000900.hL_2z_yY_NIvGNLzf6_XJ7oZSGcTsWS_E8pJKWZeBLk@z> (raw)
In-Reply-To: <m3k71vnt7j.fsf@coconut.kealia.com>

David Carlton writes:
 > Here's a revision for my patch for PR c++/1553 that I posted a couple
 > of weeks ago.  The stuff that was in that patch hasn't changed (except
 > for syncing it up with current sources), but this version also
 > includes changes to determine_prefix.  Specifically, it fixes a bug in
 > that code that Daniel pointed out, and it rewrites determine_prefix to
 > use my new determine_class_name function (so that all the class name
 > lookup stuff is in one place) and to look at TYPE_TAG_NAME (to avoid
 > recalculating the same name over and over again if possible).
 > 
 > The determine_prefix stuff could be a separate patch from my earlier
 > changes; I just wanted to get it submitted now because it's possible
 > that there will be a hiccup in my copyright assignment.  Also, it
 > seems like a good idea to get patches into 6.1 as early as possible,
 > to increase the amount of testing that they'll get.
 > 
 > I couldn't come up with any test cases for the new part of the patch;
 > it depends very much on how the compiler is generating output. :-(
 > 
 > Tested on i686-pc-linux-gnu, DWARF-2, several different GCC versions.
 > Ok for mainline and 6.1?
 > 

seems ok, however I wasn't able to apply it cleanly.
Also, there are a couple of C++ style comments that should go.

elena


  parent reply	other threads:[~2004-03-15 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-08 17:29 David Carlton
2004-03-12 17:47 ` David Carlton
2004-03-19  0:09   ` David Carlton
2004-03-15 19:26 ` Elena Zannoni [this message]
2004-03-15 22:45   ` David Carlton
2004-03-19  0:09     ` David Carlton
2004-03-19  0:09   ` Elena Zannoni
2004-03-19  0:09 ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16470.493.253043.158843@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=carlton@kealia.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox