Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@transmeta.com>
To: Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com>
Cc: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com
Subject: [PATCH] fix trap in parallel for m32r-sim
Date: Fri, 16 Jan 2004 03:43:00 -0000	[thread overview]
Message-ID: <16391.23988.251985.754761@claire.transmeta.com> (raw)
In-Reply-To: <005301c3dbe1$6352c840$2569910a@tool.maec.co.jp>

Kazuhiro Inaoka writes:
 > Hi Andrew,
 > 
 > This is a patch for illegal trap operation in parallel. 
 > 
 > Please commit it.
 > 
 > sim/m32r/ChangeLog
 > 
 > 2004-01-16  Kazuhiro Inaoka < inaoka dot kazuhiro at renesas dot com >
 > 
 >  * mloopx.in (emit_parallel,emit_full_parallel,xextract-pbb): Fixed
 >         trap operation in parallel.
 >  * mloop2.in (emit_parallel,emit_full_parallel,xextract-pbb): Ditto.
 > 
 > Regards,
 > 
 > Kazuhiro Inaoka

There's no documentation here that indicates why things are being
done the way they are.
If it were my call, I would require more comments.
i.e. _why_ is "trap || insn" being treated as "insn -> trap".
This seems like an erroneous thing to do at first glance,
ergo the need for comments explaining why things are the way they are.
Does h/w really work that way?

Also, if things are indeed kosher, why the added FIXMEs?

Also, nit: it's unfortunate that instructions are being specified
as magic numbers, but that can be fixed later.


  reply	other threads:[~2004-01-16  3:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-16  3:26 Kazuhiro Inaoka
2004-01-16  3:43 ` Doug Evans [this message]
2004-01-16  5:56   ` Kazuhiro Inaoka
2004-01-16 21:11     ` Doug Evans
2004-01-19  6:29       ` Kazuhiro Inaoka
2004-01-19 23:05         ` Doug Evans
2004-01-20  4:57           ` Kazuhiro Inaoka
2004-01-27  3:53         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16391.23988.251985.754761@claire.transmeta.com \
    --to=dje@transmeta.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=inaoka.kazuhiro@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox