From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@kealia.com>
Cc: gdb-patches@sources.redhat.com,
Elena Zannoni <ezannoni@redhat.com>, Jim Blandy <jimb@redhat.com>
Subject: Re: [rfa] generate fully-qualified names for types
Date: Thu, 08 Jan 2004 20:04:00 -0000 [thread overview]
Message-ID: <16381.46983.936264.534767@localhost.redhat.com> (raw)
In-Reply-To: <yf2fzglimzd.fsf@hawaii.kealia.com>
As usual I'd like to split this patch in mechanical
changes/replacements and not so mechanical ones. After the mechanical
changes are in, it would be more obvious what has changed.
It looks ok to me, but I'd like to minimize the diffs and take another look.
I can see:
1. the processing_current_namespace --> processing_current_prefix rename
2. the read_namespace changes of previous namespace-->previous_prefix
3. introduction of namespace_name()
as mechanical/obvious
I can check in those changes if you are busy. I am too, but now I can
swing a day for this.
Other minor nag is about comments, I think we need more examples in
the comments about how the names get composed, etc.
elena
next prev parent reply other threads:[~2004-01-08 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 18:53 David Carlton
2003-11-17 16:52 ` Daniel Jacobowitz
2003-11-18 17:51 ` David Carlton
2004-01-08 20:04 ` Elena Zannoni [this message]
2004-01-09 22:41 ` Elena Zannoni
2004-01-14 17:02 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16381.46983.936264.534767@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=carlton@kealia.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox