From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11441 invoked by alias); 8 Jan 2004 20:04:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11426 invoked from network); 8 Jan 2004 20:04:26 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 8 Jan 2004 20:04:26 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 092D71A440D; Thu, 8 Jan 2004 15:03:20 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16381.46983.936264.534767@localhost.redhat.com> Date: Thu, 08 Jan 2004 20:04:00 -0000 To: David Carlton Cc: gdb-patches@sources.redhat.com, Elena Zannoni , Jim Blandy Subject: Re: [rfa] generate fully-qualified names for types In-Reply-To: References: <20031117165209.GA15811@nevyn.them.org> X-SW-Source: 2004-01/txt/msg00213.txt.bz2 As usual I'd like to split this patch in mechanical changes/replacements and not so mechanical ones. After the mechanical changes are in, it would be more obvious what has changed. It looks ok to me, but I'd like to minimize the diffs and take another look. I can see: 1. the processing_current_namespace --> processing_current_prefix rename 2. the read_namespace changes of previous namespace-->previous_prefix 3. introduction of namespace_name() as mechanical/obvious I can check in those changes if you are busy. I am too, but now I can swing a day for this. Other minor nag is about comments, I think we need more examples in the comments about how the names get composed, etc. elena