From: Elena Zannoni <ezannoni@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com, nickc@redhat.com, rearnsha@arm.com
Subject: Re: [PATCH/RFC] coffread.c: delete param
Date: Wed, 05 Nov 2003 15:30:00 -0000 [thread overview]
Message-ID: <16297.6027.142144.968690@localhost.redhat.com> (raw)
In-Reply-To: <16268.28727.18741.65995@localhost.redhat.com>
Elena Zannoni writes:
>
> Based on the discussion in this thread:
> http://sources.redhat.com/ml/gdb-patches/2003-10/msg00405.html
>
> I don't have a set up to test this, though. It does build, that's all
> I can say.
>
> [Richard, Nick, this does affect arm-coff]
>
> elena
>
committed.
elena
> 2003-10-14 Elena Zannoni <ezannoni@redhat.com>
>
> * coffread.c (coff_symtab_read): Remove passing of info parameter
> to prim_record_minimal_symbol_and_info.
>
> Index: coffread.c
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/coffread.c,v
> retrieving revision 1.45
> diff -u -p -r1.45 coffread.c
> --- coffread.c 21 Sep 2003 01:26:44 -0000 1.45
> +++ coffread.c 14 Oct 2003 21:37:31 -0000
> @@ -926,15 +926,8 @@ coff_symtab_read (long symtab_offset, un
> if (cs->c_name[0] != '@' /* Skip tdesc symbols */ )
> {
> struct minimal_symbol *msym;
> -
> - /* FIXME: cagney/2001-02-01: The nasty (int) -> (long)
> - -> (void*) cast is to ensure that that the value of
> - cs->c_sclass can be correctly stored in a void
> - pointer in MSYMBOL_INFO. Better solutions
> - welcome. */
> - gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass));
> msym = prim_record_minimal_symbol_and_info
> - (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass,
> + (cs->c_name, tmpaddr, ms_type, NULL,
> sec, NULL, objfile);
> if (msym)
> COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym);
next prev parent reply other threads:[~2003-11-05 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-14 21:41 Elena Zannoni
2003-10-15 8:56 ` Richard Earnshaw
2003-10-15 15:10 ` Andrew Cagney
2003-10-15 15:25 ` Nick Clifton
2003-10-15 15:39 ` Andrew Cagney
2003-10-15 15:59 ` Elena Zannoni
2003-11-05 15:30 ` Elena Zannoni [this message]
2003-10-15 16:26 Michael Elizabeth Chastain
2003-10-15 16:37 ` Elena Zannoni
2003-10-15 16:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16297.6027.142144.968690@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickc@redhat.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox