From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24442 invoked by alias); 5 Nov 2003 15:30:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24433 invoked from network); 5 Nov 2003 15:30:26 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Nov 2003 15:30:26 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 4C3191A4291; Wed, 5 Nov 2003 10:30:19 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16297.6027.142144.968690@localhost.redhat.com> Date: Wed, 05 Nov 2003 15:30:00 -0000 To: Elena Zannoni Cc: gdb-patches@sources.redhat.com, nickc@redhat.com, rearnsha@arm.com Subject: Re: [PATCH/RFC] coffread.c: delete param In-Reply-To: <16268.28727.18741.65995@localhost.redhat.com> References: <16268.28727.18741.65995@localhost.redhat.com> X-SW-Source: 2003-11/txt/msg00058.txt.bz2 Elena Zannoni writes: > > Based on the discussion in this thread: > http://sources.redhat.com/ml/gdb-patches/2003-10/msg00405.html > > I don't have a set up to test this, though. It does build, that's all > I can say. > > [Richard, Nick, this does affect arm-coff] > > elena > committed. elena > 2003-10-14 Elena Zannoni > > * coffread.c (coff_symtab_read): Remove passing of info parameter > to prim_record_minimal_symbol_and_info. > > Index: coffread.c > =================================================================== > RCS file: /cvs/uberbaum/gdb/coffread.c,v > retrieving revision 1.45 > diff -u -p -r1.45 coffread.c > --- coffread.c 21 Sep 2003 01:26:44 -0000 1.45 > +++ coffread.c 14 Oct 2003 21:37:31 -0000 > @@ -926,15 +926,8 @@ coff_symtab_read (long symtab_offset, un > if (cs->c_name[0] != '@' /* Skip tdesc symbols */ ) > { > struct minimal_symbol *msym; > - > - /* FIXME: cagney/2001-02-01: The nasty (int) -> (long) > - -> (void*) cast is to ensure that that the value of > - cs->c_sclass can be correctly stored in a void > - pointer in MSYMBOL_INFO. Better solutions > - welcome. */ > - gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass)); > msym = prim_record_minimal_symbol_and_info > - (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass, > + (cs->c_name, tmpaddr, ms_type, NULL, > sec, NULL, objfile); > if (msym) > COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym);