From: Elena Zannoni <ezannoni@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs)
Date: Wed, 01 Oct 2003 20:26:00 -0000 [thread overview]
Message-ID: <16251.15087.738125.813533@localhost.redhat.com> (raw)
In-Reply-To: <20030926111405.GG22787@cygbert.vinschen.de>
Corinna Vinschen writes:
> On Thu, Sep 25, 2003 at 05:48:50PM -0400, Elena Zannoni wrote:
> > Corinna Vinschen writes:
> > > Ok, step 1:
> >
> > Seems ok, are there diffs in the test results before&after?
>
> No.
>
> > Are these
> > explanations also in the code?
>
> Yes.
>
> > > If you don't like that and want to use register_size correctly in that case,
> > > it would have to look like this:
> >
> > Yes please.
> >
> > When you are done with this rewrite, it would be good to pass the file
> > through gdb_indent.sh.
>
> Yes. Anything else left before approval?
>
No, but check in the patch with the changes corresponding to the
changelog entries below.
After that, check in the reindentation, and add a new changelog entry
saying you ran it through gdb_indent.sh.
thanks
elena
ChangeLog:
==========
* sh-tdep.c (sh_justify_value_in_reg): New function.
(sh_stack_allocsize): Ditto.
(flt_argreg_array): New array used for floating point argument
passing.
(sh_init_flt_argreg): New function.
(sh_next_flt_argreg): Ditto.
(sh_push_dummy_call_fpu): Simplify. Rename "odd_sized_struct" to
"pass_on_stack". Use new helper functions. Accomodate Renesas ABI.
Fix argument passing strategy.
(sh_push_dummy_call_nofpu): Ditto.
next prev parent reply other threads:[~2003-10-01 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-17 16:11 [RFA] sh-tdep.c: Follow up patch to implement two different ABIs Corinna Vinschen
2003-09-23 20:34 ` Elena Zannoni
2003-09-23 21:27 ` Andrew Cagney
2003-09-24 8:44 ` Corinna Vinschen
2003-09-24 9:56 ` SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs) Corinna Vinschen
2003-09-25 21:39 ` Elena Zannoni
2003-09-26 11:14 ` Corinna Vinschen
2003-10-01 20:26 ` Elena Zannoni [this message]
2003-10-02 10:47 ` Corinna Vinschen
2003-09-24 10:39 ` SH follow up, part 2 " Corinna Vinschen
2003-09-25 21:44 ` Elena Zannoni
2003-09-26 11:15 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16251.15087.738125.813533@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox