From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27452-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 26644 invoked by alias); 1 Oct 2003 20:26:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26636 invoked from network); 1 Oct 2003 20:26:47 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 1 Oct 2003 20:26:47 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h91KQk120522
	for <gdb-patches@sources.redhat.com>; Wed, 1 Oct 2003 16:26:46 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h91KQkc22669
	for <gdb-patches@sources.redhat.com>; Wed, 1 Oct 2003 16:26:46 -0400
Received: from localhost.redhat.com (devserv.devel.redhat.com [172.16.58.1])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h91KQkTX025917
	for <gdb-patches@sources.redhat.com>; Wed, 1 Oct 2003 16:26:46 -0400
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 4B9EA2CCAA; Wed,  1 Oct 2003 16:37:04 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16251.15087.738125.813533@localhost.redhat.com>
Date: Wed, 01 Oct 2003 20:26:00 -0000
To: gdb-patches@sources.redhat.com
Subject: Re: SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs)
In-Reply-To: <20030926111405.GG22787@cygbert.vinschen.de>
References: <20030917161127.GM9981@cygbert.vinschen.de>
	<16240.45203.260059.116019@localhost.redhat.com>
	<20030924095552.GA8414@cygbert.vinschen.de>
	<16243.25282.58326.132364@localhost.redhat.com>
	<20030926111405.GG22787@cygbert.vinschen.de>
X-SW-Source: 2003-10/txt/msg00013.txt.bz2

Corinna Vinschen writes:
 > On Thu, Sep 25, 2003 at 05:48:50PM -0400, Elena Zannoni wrote:
 > > Corinna Vinschen writes:
 > >  > Ok, step 1:
 > > 
 > > Seems ok, are there diffs in the test results before&after?
 > 
 > No.
 > 
 > >   Are these
 > > explanations also in the code?
 > 
 > Yes.
 > 
 > > > If you don't like that and want to use register_size correctly in that case,
 > > > it would have to look like this:
 > > 
 > > Yes please.
 > > 
 > > When you are done with this rewrite, it would be good to pass the file
 > > through gdb_indent.sh.
 > 
 > Yes.  Anything else left before approval?
 > 

No, but check in the patch with the changes corresponding to the
changelog entries below.

After that, check in the reindentation, and add a new changelog entry
saying you ran it through gdb_indent.sh.

thanks
elena

ChangeLog:
==========

	* sh-tdep.c (sh_justify_value_in_reg): New function.
	(sh_stack_allocsize): Ditto.
	(flt_argreg_array): New array used for floating point argument
	passing.
	(sh_init_flt_argreg): New function.
	(sh_next_flt_argreg): Ditto.
	(sh_push_dummy_call_fpu): Simplify. Rename "odd_sized_struct" to
	"pass_on_stack". Use new helper functions.  Accomodate Renesas ABI.
	Fix argument passing strategy.
	(sh_push_dummy_call_nofpu): Ditto.