From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Cc: gaius@glam.ac.uk
Subject: [RFC] logic change in m2-valprint.c
Date: Fri, 29 Jun 2007 00:37:00 -0000 [thread overview]
Message-ID: <16087.12.7.175.2.1183076995.squirrel@webmail.sonic.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
I'm really not sure about this, call it a shot in the dark.
The logic doesn't make sense as it is (the condition can't be true),
so I figured maybe the conditional had been reversed by mistake.
Either that, or the two lines should be removed, 'cause they're dead.
[-- Attachment #2: m2.txt --]
[-- Type: text/plain, Size: 897 bytes --]
2007-06-28 Michael Snyder <msnyder@access-company.com>
* m2-valprint.c (m2_print_long_set): Logical condition reversed
(Coverity).
Index: m2-valprint.c
===================================================================
RCS file: /cvs/src/src/gdb/m2-valprint.c,v
retrieving revision 1.12
diff -p -r1.12 m2-valprint.c
*** m2-valprint.c 9 Jan 2007 17:58:51 -0000 1.12
--- m2-valprint.c 29 Jun 2007 00:25:56 -0000
*************** m2_print_long_set (struct type *type, co
*** 132,138 ****
previous_high = i;
if (! element_seen)
{
! if (! empty_set)
fprintf_filtered (stream, ", ");
print_type_scalar (target, i, stream);
empty_set = 0;
--- 132,138 ----
previous_high = i;
if (! element_seen)
{
! if (empty_set)
fprintf_filtered (stream, ", ");
print_type_scalar (target, i, stream);
empty_set = 0;
next reply other threads:[~2007-06-29 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 0:37 msnyder [this message]
2007-07-01 15:49 ` Daniel Jacobowitz
2007-07-01 15:54 ` Michael Snyder
2007-07-01 16:03 ` Daniel Jacobowitz
2007-07-03 0:05 ` msnyder
2007-07-03 1:12 ` Daniel Jacobowitz
2007-07-03 1:21 ` msnyder
2007-07-03 1:24 ` Daniel Jacobowitz
2007-07-03 1:40 ` msnyder
2007-07-03 7:42 ` Mark Kettenis
2007-07-03 19:26 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16087.12.7.175.2.1183076995.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gaius@glam.ac.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox