From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25281 invoked by alias); 29 Jun 2007 00:30:03 -0000 Received: (qmail 25268 invoked by uid 22791); 29 Jun 2007 00:30:02 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 29 Jun 2007 00:29:59 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l5T0Ttv0005138; Thu, 28 Jun 2007 17:29:55 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Thu, 28 Jun 2007 17:29:55 -0700 (PDT) Message-ID: <16087.12.7.175.2.1183076995.squirrel@webmail.sonic.net> Date: Fri, 29 Jun 2007 00:37:00 -0000 Subject: [RFC] logic change in m2-valprint.c From: msnyder@sonic.net To: gdb-patches@sourceware.org Cc: gaius@glam.ac.uk User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20070628172955_13028" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00512.txt.bz2 ------=_20070628172955_13028 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-length: 267 I'm really not sure about this, call it a shot in the dark. The logic doesn't make sense as it is (the condition can't be true), so I figured maybe the conditional had been reversed by mistake. Either that, or the two lines should be removed, 'cause they're dead. ------=_20070628172955_13028 Content-Type: text/plain; name="m2.txt" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="m2.txt" Content-length: 897 2007-06-28 Michael Snyder * m2-valprint.c (m2_print_long_set): Logical condition reversed (Coverity). Index: m2-valprint.c =================================================================== RCS file: /cvs/src/src/gdb/m2-valprint.c,v retrieving revision 1.12 diff -p -r1.12 m2-valprint.c *** m2-valprint.c 9 Jan 2007 17:58:51 -0000 1.12 --- m2-valprint.c 29 Jun 2007 00:25:56 -0000 *************** m2_print_long_set (struct type *type, co *** 132,138 **** previous_high = i; if (! element_seen) { ! if (! empty_set) fprintf_filtered (stream, ", "); print_type_scalar (target, i, stream); empty_set = 0; --- 132,138 ---- previous_high = i; if (! element_seen) { ! if (empty_set) fprintf_filtered (stream, ", "); print_type_scalar (target, i, stream); empty_set = 0; ------=_20070628172955_13028--