From: Elena Zannoni <ezannoni@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA/symtab: Let search_symbols find exact matches
Date: Fri, 21 Feb 2003 15:27:00 -0000 [thread overview]
Message-ID: <15958.18025.295955.608797@localhost.redhat.com> (raw)
In-Reply-To: <20030221140925.GA31205@nevyn.them.org>
Daniel Jacobowitz writes:
> On Thu, Feb 20, 2003 at 02:41:18PM -0800, David Carlton wrote:
> > On Mon, 10 Feb 2003 11:01:07 -0500, Daniel Jacobowitz <drow@mvista.com> said:
> >
> > > This patch renames search_symbols to search_symbols_aux, and lets it take an
> > > argument that specified regex or exact (well, strcmp_iw) matching. Then
> > > search_symbols becomes a wrapper.
> >
> > > The new function is used by make_symbol_overload_list, which shaves 50% time
> > > off of some tests in the C++ directory if your system libc has debugging
> > > symbols; it removes the bogusity where all psymtabs were converted to
> > > symtabs during overload resolution. Whew. This cuts memory for
> > > namespace.exp from 70MB to 7MB, allowing some of my hardware to actually run
> > > the test without crashing.
> >
> > Here's take two on my comments on this. First, I should say that I
> > totally agree that the aforementioned bogusity in
> > make_symbol_overload_list should go; as discussed in
> > <http://sources.redhat.com/ml/gdb-patches/2003-02/msg00261.html>,
> > though, there are ways of doing that that involve much less drastic
> > changes.
>
> Good enough for me. This patch is withdrawn. David, are you convinced
> that lookup_partial_symbol is close enough to what we want for the
> patch above? You expressed some concerns earlier. If you're happy
> with it, I'll approve the patch.
>
As a matter of fact, could these c++ specific functions be moved to
cp-support.c? So you guys are free to do whatever you want with them.
If the patch is withdrawn please close the pr.
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-02-21 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-10 16:01 Daniel Jacobowitz
2003-02-10 20:10 ` David Carlton
2003-02-10 20:18 ` David Carlton
2003-02-10 20:25 ` Daniel Jacobowitz
2003-02-10 21:15 ` David Carlton
2003-02-10 21:17 ` Daniel Jacobowitz
2003-02-20 22:41 ` David Carlton
2003-02-21 14:10 ` Daniel Jacobowitz
2003-02-21 15:27 ` Elena Zannoni [this message]
2003-02-21 17:14 ` David Carlton
2003-02-21 17:09 ` David Carlton
2003-02-25 0:35 ` David Carlton
2003-02-21 19:15 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15958.18025.295955.608797@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox