From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16177 invoked by alias); 21 Feb 2003 15:27:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16163 invoked from network); 21 Feb 2003 15:27:48 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 21 Feb 2003 15:27:48 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1LFRmN01781 for ; Fri, 21 Feb 2003 10:27:48 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1LFRlf26005 for ; Fri, 21 Feb 2003 10:27:47 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1LFRlt03837 for ; Fri, 21 Feb 2003 10:27:47 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 6E365FF79; Fri, 21 Feb 2003 10:31:53 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15958.18025.295955.608797@localhost.redhat.com> Date: Fri, 21 Feb 2003 15:27:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFA/symtab: Let search_symbols find exact matches In-Reply-To: <20030221140925.GA31205@nevyn.them.org> References: <20030210160107.GA587@nevyn.them.org> <20030221140925.GA31205@nevyn.them.org> X-SW-Source: 2003-02/txt/msg00517.txt.bz2 Daniel Jacobowitz writes: > On Thu, Feb 20, 2003 at 02:41:18PM -0800, David Carlton wrote: > > On Mon, 10 Feb 2003 11:01:07 -0500, Daniel Jacobowitz said: > > > > > This patch renames search_symbols to search_symbols_aux, and lets it take an > > > argument that specified regex or exact (well, strcmp_iw) matching. Then > > > search_symbols becomes a wrapper. > > > > > The new function is used by make_symbol_overload_list, which shaves 50% time > > > off of some tests in the C++ directory if your system libc has debugging > > > symbols; it removes the bogusity where all psymtabs were converted to > > > symtabs during overload resolution. Whew. This cuts memory for > > > namespace.exp from 70MB to 7MB, allowing some of my hardware to actually run > > > the test without crashing. > > > > Here's take two on my comments on this. First, I should say that I > > totally agree that the aforementioned bogusity in > > make_symbol_overload_list should go; as discussed in > > , > > though, there are ways of doing that that involve much less drastic > > changes. > > Good enough for me. This patch is withdrawn. David, are you convinced > that lookup_partial_symbol is close enough to what we want for the > patch above? You expressed some concerns earlier. If you're happy > with it, I'll approve the patch. > As a matter of fact, could these c++ specific functions be moved to cp-support.c? So you guys are free to do whatever you want with them. If the patch is withdrawn please close the pr. > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer