Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/ping] lib/gdb.exp: remove LC_ALL=C workaround for readline bug
Date: Thu, 30 Jan 2003 23:36:00 -0000	[thread overview]
Message-ID: <15929.47109.10167.737690@localhost.redhat.com> (raw)
In-Reply-To: <200301302329.h0UNTwn16671@duracef.shout.net>

Michael Elizabeth Chastain writes:
 > It's been a week, and I haven't gotten any response yet.
 > Ping ...

Hmm, I can approve this. It is quite obvious.

thanks
elena


 > 
 > This patch reverts a recent patch in lib/gdb.exp:
 > 
 >   2003-01-06  Andreas Schwab  <schwab@suse.de>
 > 
 > 	* lib/gdb.exp: Set LC_ALL to "C" to avoid spurious testsuite
 > 	failures.
 > 
 > Setting LC_ALL is a workaround for a bug in readline 4.3 regarding
 > perverse screen refresh in a UTF-8 locale.
 > 
 > Chet Ramey, the readline maintainer, send me a patch for this,
 > and I committed that patch to gdb HEAD on 2003-01-09.  So we don't need
 > this work around any more.
 > 
 > Testing: I tested this with: target=native, host=i686-pc-linux-gnu,
 > osversion=red-hat-8.0, LANG=en_US.UTF-8.  I tested with gcc v2 and v3,
 > dwarf-2 and stabs+.
 > 
 > OK to commit?
 > 
 > Michael C
 > 
 > 2003-01-21  Michael Chastain  <mec@shout.net>
 > 
 > 	* lib/gdb.exp: Revert patch of 2003-01-06, which set LC_ALL.
 > 	This was a workaround for a UTF-8 bug in readline 4.3.  The bug
 > 	has been fixed in gdb/readline on 2003-01-09.
 > 
 > Index: lib/gdb.exp
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
 > retrieving revision 1.32
 > diff -u -r1.32 gdb.exp
 > --- lib/gdb.exp	6 Jan 2003 18:10:32 -0000	1.32
 > +++ lib/gdb.exp	21 Jan 2003 21:46:07 -0000
 > @@ -64,9 +64,6 @@
 >      set EXEEXT $env(EXEEXT)
 >  }
 >  
 > -# Make sure we are using the C locale.
 > -set env(LC_ALL) "C"
 > -
 >  ### Only procedures should come after this point.
 >  
 >  #


  reply	other threads:[~2003-01-30 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-30 23:30 Michael Elizabeth Chastain
2003-01-30 23:36 ` Elena Zannoni [this message]
2003-01-31  3:40 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15929.47109.10167.737690@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox