From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26766 invoked by alias); 30 Jan 2003 23:36:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26758 invoked from network); 30 Jan 2003 23:36:40 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 30 Jan 2003 23:36:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0UNaef09384 for ; Thu, 30 Jan 2003 18:36:40 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0UNada24826 for ; Thu, 30 Jan 2003 18:36:39 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0UNadc24749 for ; Thu, 30 Jan 2003 18:36:39 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 2B4FCFF79; Thu, 30 Jan 2003 18:40:53 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15929.47109.10167.737690@localhost.redhat.com> Date: Thu, 30 Jan 2003 23:36:00 -0000 To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/ping] lib/gdb.exp: remove LC_ALL=C workaround for readline bug In-Reply-To: <200301302329.h0UNTwn16671@duracef.shout.net> References: <200301302329.h0UNTwn16671@duracef.shout.net> X-SW-Source: 2003-01/txt/msg00822.txt.bz2 Michael Elizabeth Chastain writes: > It's been a week, and I haven't gotten any response yet. > Ping ... Hmm, I can approve this. It is quite obvious. thanks elena > > This patch reverts a recent patch in lib/gdb.exp: > > 2003-01-06 Andreas Schwab > > * lib/gdb.exp: Set LC_ALL to "C" to avoid spurious testsuite > failures. > > Setting LC_ALL is a workaround for a bug in readline 4.3 regarding > perverse screen refresh in a UTF-8 locale. > > Chet Ramey, the readline maintainer, send me a patch for this, > and I committed that patch to gdb HEAD on 2003-01-09. So we don't need > this work around any more. > > Testing: I tested this with: target=native, host=i686-pc-linux-gnu, > osversion=red-hat-8.0, LANG=en_US.UTF-8. I tested with gcc v2 and v3, > dwarf-2 and stabs+. > > OK to commit? > > Michael C > > 2003-01-21 Michael Chastain > > * lib/gdb.exp: Revert patch of 2003-01-06, which set LC_ALL. > This was a workaround for a UTF-8 bug in readline 4.3. The bug > has been fixed in gdb/readline on 2003-01-09. > > Index: lib/gdb.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v > retrieving revision 1.32 > diff -u -r1.32 gdb.exp > --- lib/gdb.exp 6 Jan 2003 18:10:32 -0000 1.32 > +++ lib/gdb.exp 21 Jan 2003 21:46:07 -0000 > @@ -64,9 +64,6 @@ > set EXEEXT $env(EXEEXT) > } > > -# Make sure we are using the C locale. > -set env(LC_ALL) "C" > - > ### Only procedures should come after this point. > > #