From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [patch] linespec.c: rename 's' to 'file_symtab'
Date: Sun, 12 Jan 2003 18:26:00 -0000 [thread overview]
Message-ID: <15905.46188.901259.762664@localhost.redhat.com> (raw)
In-Reply-To: <ro1r8bkbimf.fsf@jackfruit.Stanford.EDU>
David Carlton writes:
> This patch renames the variable 's' to 'file_symtab' in decode_line_1,
> as well as in the functions to which decode_line_1 passes it as an
> argument.
>
> Tested on i686-pc-linux-gnu/GCC 3.1/DWARF-2. Committed as obvious.
>
> And yes, Elena's probably annoyed at me right now for committing a
> 200-line patch as obvious, despite her request to keep them short. :-)
> But it really is obvious: if you look at the patch, every single line
> just changes 's' to 'file_symtab', and if I missed any places to
> change it, the compiler would have been happy to inform me. (Though I
> did run the testsuite as well, because I'm anal.) Don't worry: my
> future 'obvious' patches will be much shorter, this one just happens
> to rename a variable that occurs all over the place.
>
> David Carlton
> carlton@math.stanford.edu
>
Nah, you won't incur into Elena's wrath this time. :-)
Elena
prev parent reply other threads:[~2003-01-12 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 1:06 David Carlton
2003-01-12 18:26 ` Elena Zannoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15905.46188.901259.762664@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=carlton@math.stanford.edu \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox