From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ezannoni@redhat.com>
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Received: (qmail 11763 invoked from network); 12 Jan 2003 18:26:59 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by 209.249.29.67 with SMTP; 12 Jan 2003 18:26:59 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0CHwjB00362
	for <gdb-patches@sources.redhat.com>; Sun, 12 Jan 2003 12:58:45 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0CIQla23898
	for <gdb-patches@sources.redhat.com>; Sun, 12 Jan 2003 13:26:47 -0500
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0CIQkS15123;
	Sun, 12 Jan 2003 13:26:46 -0500
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 487B5FF79; Sun, 12 Jan 2003 13:31:09 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15905.46188.901259.762664@localhost.redhat.com>
Date: Sun, 12 Jan 2003 18:26:00 -0000
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [patch] linespec.c: rename 's' to 'file_symtab'
In-Reply-To: <ro1r8bkbimf.fsf@jackfruit.Stanford.EDU>
References: <ro1r8bkbimf.fsf@jackfruit.Stanford.EDU>
X-SW-Source: 2003-01/txt/msg00468.txt.bz2

David Carlton writes:
 > This patch renames the variable 's' to 'file_symtab' in decode_line_1,
 > as well as in the functions to which decode_line_1 passes it as an
 > argument.
 > 
 > Tested on i686-pc-linux-gnu/GCC 3.1/DWARF-2.  Committed as obvious.
 > 
 > And yes, Elena's probably annoyed at me right now for committing a
 > 200-line patch as obvious, despite her request to keep them short. :-)
 > But it really is obvious: if you look at the patch, every single line
 > just changes 's' to 'file_symtab', and if I missed any places to
 > change it, the compiler would have been happy to inform me.  (Though I
 > did run the testsuite as well, because I'm anal.)  Don't worry: my
 > future 'obvious' patches will be much shorter, this one just happens
 > to rename a variable that occurs all over the place.
 > 
 > David Carlton
 > carlton@math.stanford.edu
 > 


Nah, you won't incur into Elena's wrath this time. :-)

Elena