Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com,
	Elena Zannoni <ezannoni@redhat.com>, Jim Blandy <jimb@redhat.com>,
	Fernando Nasser <fnasser@redhat.com>
Subject: Re: [rfa] linespec.c, part 2
Date: Mon, 11 Nov 2002 07:42:00 -0000	[thread overview]
Message-ID: <15823.52942.697332.441926@localhost.redhat.com> (raw)
In-Reply-To: <ro1adkjalf6.fsf@jackfruit.Stanford.EDU>

David Carlton writes:
 > Here's part 2 of the linespec patches.  This one's quite
 > straightforward; it just moves two chunks of code from the beginning
 > of decode_line_1 to separate functions initialize_defaults and
 > decode_indirect.  Also, it turns out that, later in decode_line_1,
 > defaults get re-initialized, so I turned that into a second call to
 > initialize_defaults.
 > 
 > David Carlton
 > carlton@math.stanford.edu
 > 
 > 2002-11-07  David Carlton  <carlton@math.stanford.edu>
 > 
 > 	* linespec.c (decode_line_1): Move chunks of code to separate
 > 	functions.
 > 	(initialize_defaults): New function.
 > 	(decode_indirect): New function.
 > 
 >     *     (gdb) break foo if (a==b)
 > @@ -1034,10 +1015,7 @@ decode_line_1 (char **argptr, int funfir
 >  
 >  	  /* Make sure we have at least a default source file. */
 >  	  set_default_source_symtab_and_line ();

Shouldn't this line go too?
struct symtab_and_line cursal;

Othewise OK.

Elena



  reply	other threads:[~2002-11-11 15:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-08 11:52 David Carlton
2002-11-11  7:42 ` Elena Zannoni [this message]
2002-11-11 17:15   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15823.52942.697332.441926@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=carlton@math.stanford.edu \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox