From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20049-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 25011 invoked by alias); 11 Nov 2002 15:42:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24978 invoked from network); 11 Nov 2002 15:42:02 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 11 Nov 2002 15:42:02 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gABFJ1w21502
	for <gdb-patches@sources.redhat.com>; Mon, 11 Nov 2002 10:19:01 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gABFg1D02565;
	Mon, 11 Nov 2002 10:42:01 -0500
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gABFfxV05072;
	Mon, 11 Nov 2002 10:42:00 -0500
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 1D83AFF79; Mon, 11 Nov 2002 10:37:50 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15823.52942.697332.441926@localhost.redhat.com>
Date: Mon, 11 Nov 2002 07:42:00 -0000
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>,
   Jim Blandy <jimb@redhat.com>, Fernando Nasser <fnasser@redhat.com>
Subject: Re: [rfa] linespec.c, part 2
In-Reply-To: <ro1adkjalf6.fsf@jackfruit.Stanford.EDU>
References: <ro1adkjalf6.fsf@jackfruit.Stanford.EDU>
X-SW-Source: 2002-11/txt/msg00305.txt.bz2

David Carlton writes:
 > Here's part 2 of the linespec patches.  This one's quite
 > straightforward; it just moves two chunks of code from the beginning
 > of decode_line_1 to separate functions initialize_defaults and
 > decode_indirect.  Also, it turns out that, later in decode_line_1,
 > defaults get re-initialized, so I turned that into a second call to
 > initialize_defaults.
 > 
 > David Carlton
 > carlton@math.stanford.edu
 > 
 > 2002-11-07  David Carlton  <carlton@math.stanford.edu>
 > 
 > 	* linespec.c (decode_line_1): Move chunks of code to separate
 > 	functions.
 > 	(initialize_defaults): New function.
 > 	(decode_indirect): New function.
 > 
 >     *     (gdb) break foo if (a==b)
 > @@ -1034,10 +1015,7 @@ decode_line_1 (char **argptr, int funfir
 >  
 >  	  /* Make sure we have at least a default source file. */
 >  	  set_default_source_symtab_and_line ();

Shouldn't this line go too?
struct symtab_and_line cursal;

Othewise OK.

Elena