Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@redhat.com>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: change for gdb/mi 495
Date: Tue, 22 Oct 2002 09:00:00 -0000	[thread overview]
Message-ID: <15797.30097.60141.274031@localhost.redhat.com> (raw)
In-Reply-To: <3DB496BD.E55975B1@redhat.com>

J. Johnston writes:
 > The following is a patch for gdb/mi 495.  The PR requests changing ui_out_field_core_addr
 > to use core_addr_to_string().
 > 
 > Ok to commit?
 > 

I think it is ok. No unexpected changes in the output, I take it.

Elena


 > -- Jeff J.
 > 
 > gdb/ChangeLog:
 > 
 > 2002-10-21  Jeff Johnston  <jjohnstn@redhat.com>
 > 
 > 	* ui-out.c (ui_out_field_core_addr): Change to call core_addr_to_string().Index: ui-out.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/ui-out.c,v
 > retrieving revision 1.24
 > diff -u -r1.24 ui-out.c
 > --- ui-out.c	3 Oct 2002 22:34:58 -0000	1.24
 > +++ ui-out.c	22 Oct 2002 00:02:17 -0000
 > @@ -507,16 +507,7 @@
 >  			const char *fldname,
 >  			CORE_ADDR address)
 >  {
 > -  char addstr[20];
 > -
 > -  /* FIXME: cagney/2002-05-03: Need local_address_string() function
 > -     that returns the language localized string formatted to a width
 > -     based on TARGET_ADDR_BIT.  */
 > -  /* print_address_numeric (address, 1, local_stream); */
 > -  if (TARGET_ADDR_BIT <= 32)
 > -    strcpy (addstr, local_hex_string_custom (address, "08l"));
 > -  else
 > -    strcpy (addstr, local_hex_string_custom (address, "016l"));
 > +  const char *addstr = core_addr_to_string (address);
 >  
 >    ui_out_field_string (uiout, fldname, addstr);
 >  }


  reply	other threads:[~2002-10-22 16:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-21 17:07 J. Johnston
2002-10-22  9:00 ` Elena Zannoni [this message]
2002-10-22  9:31   ` Andrew Cagney
2002-10-22  9:49     ` Elena Zannoni
2002-11-13 11:24     ` J. Johnston
2003-01-08  0:07     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15797.30097.60141.274031@localhost.redhat.com \
    --to=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox