From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22288 invoked by alias); 22 Oct 2002 16:00:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22264 invoked from network); 22 Oct 2002 16:00:52 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Oct 2002 16:00:52 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9MFdYw26743 for ; Tue, 22 Oct 2002 11:39:34 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MG0pf10789; Tue, 22 Oct 2002 12:00:51 -0400 Received: from localhost.redhat.com (IDENT:c83MUkhaDVQYoaxXoXxm3dvKFMPRJys9@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MG0ow27833; Tue, 22 Oct 2002 12:00:50 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 32071FF79; Tue, 22 Oct 2002 11:58:09 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15797.30097.60141.274031@localhost.redhat.com> Date: Tue, 22 Oct 2002 09:00:00 -0000 To: "J. Johnston" Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: change for gdb/mi 495 In-Reply-To: <3DB496BD.E55975B1@redhat.com> References: <3DB496BD.E55975B1@redhat.com> X-SW-Source: 2002-10/txt/msg00402.txt.bz2 J. Johnston writes: > The following is a patch for gdb/mi 495. The PR requests changing ui_out_field_core_addr > to use core_addr_to_string(). > > Ok to commit? > I think it is ok. No unexpected changes in the output, I take it. Elena > -- Jeff J. > > gdb/ChangeLog: > > 2002-10-21 Jeff Johnston > > * ui-out.c (ui_out_field_core_addr): Change to call core_addr_to_string().Index: ui-out.c > =================================================================== > RCS file: /cvs/src/src/gdb/ui-out.c,v > retrieving revision 1.24 > diff -u -r1.24 ui-out.c > --- ui-out.c 3 Oct 2002 22:34:58 -0000 1.24 > +++ ui-out.c 22 Oct 2002 00:02:17 -0000 > @@ -507,16 +507,7 @@ > const char *fldname, > CORE_ADDR address) > { > - char addstr[20]; > - > - /* FIXME: cagney/2002-05-03: Need local_address_string() function > - that returns the language localized string formatted to a width > - based on TARGET_ADDR_BIT. */ > - /* print_address_numeric (address, 1, local_stream); */ > - if (TARGET_ADDR_BIT <= 32) > - strcpy (addstr, local_hex_string_custom (address, "08l")); > - else > - strcpy (addstr, local_hex_string_custom (address, "016l")); > + const char *addstr = core_addr_to_string (address); > > ui_out_field_string (uiout, fldname, addstr); > }