From: Elena Zannoni <ezannoni@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Delete struct source, struct sourcevector from symtab.h
Date: Fri, 18 Oct 2002 16:41:00 -0000 [thread overview]
Message-ID: <15792.39826.169055.118672@localhost.redhat.com> (raw)
In-Reply-To: <ro1fzv38hko.fsf@jackfruit.Stanford.EDU>
David Carlton writes:
> symtab.h contains definitions for 'struct source' and 'struct
> sourcevector', but nobody ever refers to them. If you look through
> ChangeLog-1999, you see the comment:
>
> * symtab.h: Remove struct sourcevector and struct source. Definately
> not needed.
>
> But, despite that, they haven't actually been removed. Oops.
>
Are those the only references? Wow.
> Here's a patch; I've compiled and checked, and they really aren't
> referred to anywhere. OK?
>
Cool, yes, thanks.
Elena
> David Carlton
> carlton@math.stanford.edu
>
> 2002-10-18 David Carlton <carlton@math.stanford.edu>
>
> * symtab.h: Delete 'struct source' and 'struct sourcevector'.
>
> Index: symtab.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.h,v
> retrieving revision 1.43
> diff -u -p -r1.43 symtab.h
> --- symtab.h 15 Oct 2002 02:50:56 -0000 1.43
> +++ symtab.h 18 Oct 2002 22:11:11 -0000
> @@ -750,15 +750,6 @@ struct partial_symbol
> #define PSYMBOL_CLASS(psymbol) (psymbol)->aclass
> \f
>
> -/* Source-file information. This describes the relation between source files,
> - line numbers and addresses in the program text. */
> -
> -struct sourcevector
> -{
> - int length; /* Number of source files described */
> - struct source *source[1]; /* Descriptions of the files */
> -};
> -
> /* Each item represents a line-->pc (or the reverse) mapping. This is
> somewhat more wasteful of space than one might wish, but since only
> the files which are actually debugged are read in to core, we don't
> @@ -795,14 +786,6 @@ struct linetable
> `struct hack', you can shove it up your ANSI (seriously, if the
> committee tells us how to do it, we can probably go along). */
> struct linetable_entry item[1];
> -};
> -
> -/* All the information on one source file. */
> -
> -struct source
> -{
> - char *name; /* Name of file */
> - struct linetable contents;
> };
>
> /* How to relocate the symbols from each section in a symbol file.
next prev parent reply other threads:[~2002-10-18 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-18 16:15 David Carlton
2002-10-18 16:41 ` Elena Zannoni [this message]
2002-10-18 16:49 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15792.39826.169055.118672@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=carlton@math.stanford.edu \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox