From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13242 invoked by alias); 18 Oct 2002 23:41:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13224 invoked from network); 18 Oct 2002 23:41:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Oct 2002 23:41:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9INKdw29211 for ; Fri, 18 Oct 2002 19:20:39 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9INfdf19407 for ; Fri, 18 Oct 2002 19:41:39 -0400 Received: from localhost.redhat.com (IDENT:WoscgOmCklp4wfY9WOERTOiIbEThWDxI@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9INfcT17745 for ; Fri, 18 Oct 2002 19:41:38 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 555C1FF79; Fri, 18 Oct 2002 19:38:58 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15792.39826.169055.118672@localhost.redhat.com> Date: Fri, 18 Oct 2002 16:41:00 -0000 To: David Carlton Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Delete struct source, struct sourcevector from symtab.h In-Reply-To: References: X-SW-Source: 2002-10/txt/msg00316.txt.bz2 David Carlton writes: > symtab.h contains definitions for 'struct source' and 'struct > sourcevector', but nobody ever refers to them. If you look through > ChangeLog-1999, you see the comment: > > * symtab.h: Remove struct sourcevector and struct source. Definately > not needed. > > But, despite that, they haven't actually been removed. Oops. > Are those the only references? Wow. > Here's a patch; I've compiled and checked, and they really aren't > referred to anywhere. OK? > Cool, yes, thanks. Elena > David Carlton > carlton@math.stanford.edu > > 2002-10-18 David Carlton > > * symtab.h: Delete 'struct source' and 'struct sourcevector'. > > Index: symtab.h > =================================================================== > RCS file: /cvs/src/src/gdb/symtab.h,v > retrieving revision 1.43 > diff -u -p -r1.43 symtab.h > --- symtab.h 15 Oct 2002 02:50:56 -0000 1.43 > +++ symtab.h 18 Oct 2002 22:11:11 -0000 > @@ -750,15 +750,6 @@ struct partial_symbol > #define PSYMBOL_CLASS(psymbol) (psymbol)->aclass > > > -/* Source-file information. This describes the relation between source files, > - line numbers and addresses in the program text. */ > - > -struct sourcevector > -{ > - int length; /* Number of source files described */ > - struct source *source[1]; /* Descriptions of the files */ > -}; > - > /* Each item represents a line-->pc (or the reverse) mapping. This is > somewhat more wasteful of space than one might wish, but since only > the files which are actually debugged are read in to core, we don't > @@ -795,14 +786,6 @@ struct linetable > `struct hack', you can shove it up your ANSI (seriously, if the > committee tells us how to do it, we can probably go along). */ > struct linetable_entry item[1]; > -}; > - > -/* All the information on one source file. */ > - > -struct source > -{ > - char *name; /* Name of file */ > - struct linetable contents; > }; > > /* How to relocate the symbols from each section in a symbol file.